Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add geometry file docs #1184

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Add geometry file docs #1184

merged 2 commits into from
Apr 22, 2021

Conversation

hamishwillee
Copy link
Collaborator

This is just a placeholder with a lot of questions. Has video and useful links. The need was originally raised in PX4/PX4-Devguide#349

@bkueng @bresch Can you help here? Some questions inline, but really I need a practical guide to how to do this.

bresch
bresch reviewed Apr 14, 2021
View reviewed changes
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the draft, I tried to answer your questions, please tell me if something isn't clear enough.

@hamishwillee hamishwillee changed the title Add goemetry file docs Add geometry file docs Apr 21, 2021
@hamishwillee
Copy link
Collaborator Author

@bresch That is exactly what I needed :-). I've updated with all this. Ready for your review.

bresch
bresch approved these changes Apr 22, 2021
View reviewed changes
Copy link
Member

@bresch bresch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good!

@hamishwillee hamishwillee merged commit 9a47731 into master Apr 22, 2021
@hamishwillee hamishwillee deleted the geometry branch April 22, 2021 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bresch bresch bresch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamishwillee @bresch