Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

Mixing: Syntax and virtual control group info. #994

Merged
merged 2 commits into from
Mar 30, 2020

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Mar 26, 2020

Fix for #868

Note, this fixes the specific problems listed in #868. That is not to say that the mixer documentation is now perfect.

What it makes clear is:

  1. Virtual mixers are not used in mixer files.
  2. What each of the mixers are for
  3. Order and number of outputs - how they work.
  4. That detailed definitions are further down.

@hamishwillee hamishwillee marked this pull request as ready for review March 30, 2020 03:46
@hamishwillee hamishwillee requested a review from bkueng March 30, 2020 03:46
Mixer files are text files that define one or more mixer definitions: mappings between one or more inputs and one or more outputs.

There are four types of mixers definitions: [multirotor mixer](#multirotor_mixer), [helicopter mixer](#helicopter_mixer), [summing mixer](#summing_mixer), and [null mixer](#null_mixer).
- [Multirotor mixer](#multirotor_mixer) - Defines outputs for 4, 6, or 8 rotor vehicles with + or X geometry.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's more flexibility here, e.g. tricopters, or prop-in vs. prop-out. Do we have docs for the mixer geometry files under https://github.com/PX4/Firmware/tree/master/src/lib/mixer/MultirotorMixer/geometries?

Copy link
Collaborator Author

@hamishwillee hamishwillee Mar 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkueng No docs on geometry files - I'm still hoping @jlecoeur can provide the documentation: #349 :-)

I think perhaps given that Julien posted that in 2017 we should perhaps work on that now. Can you help? Specifically, what is geometry file, how do you create it, how does it then relate to the mixer. Let's continue discussion on #349?

Once that is understood perhaps I can add tricopters to this list here.

For now, I plan to merge this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right. Ok if Julien does not reply, ping me again and I can probably fill in the gaps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, it is high time to get this done

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jlecoeur Was that a commitment to getting this done at a particular time? :-) Or do I need to try get Beat to help fix this?

@hamishwillee hamishwillee merged commit 8a1e8ba into master Mar 30, 2020
@hamishwillee hamishwillee deleted the hamishwillee-mixer_defns branch March 30, 2020 21:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants