Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EKF2: fix false pre-flight failure report #24050

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bresch
Copy link
Member

@bresch bresch commented Nov 28, 2024

Solved Problem

Filtered innovations and test ratios can be large before the reset and can trigger pre-flight warnings [health_and_arming_checks] Preflight fail: height estimate not stable

image

Solution

Reset innovation and test ratio filters when resetting a state using a measurement.

Filtered innovations and test ratios can be large before the reset and
would trigger pre-flight warnings
@bresch bresch self-assigned this Nov 28, 2024
@bresch bresch mentioned this pull request Nov 28, 2024
3 tasks
Copy link

FLASH Analysis

px4_fmu-v5x
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%    +918  [ = ]       0    .debug_line
  +0.2%    +918  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%    +559  [ = ]       0    .debug_info
  +0.1%    +559  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%    +360  +0.0%    +360    .text
  +0.2%    +352  +0.2%    +352    src/modules/ekf2/modules__ekf2_unity.cpp
  +0.0%      +8  +0.0%      +8    [section .text]
+0.0%    +104  [ = ]       0    .debug_ranges
  +0.0%     +64  [ = ]       0    [section .debug_ranges]
  +0.0%     +40  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%     +32  [ = ]       0    .symtab
  +0.2%     +32  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%      +8  [ = ]       0    .debug_aranges
-0.0%    -145  [ = ]       0    .debug_loc
  +0.0%     +82  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
  -0.0%    -227  [ = ]       0    [section .debug_loc]
-1.5%    -356  [ = ]       0    [Unmapped]
+0.0% +1.45Ki  +0.0%    +360    TOTAL

px4_fmu-v6x
    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%    +918  [ = ]       0    .debug_line
  +0.2%    +918  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%    +559  [ = ]       0    .debug_info
  +0.1%    +559  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%    +352  +0.0%    +352    .text
  +0.2%    +352  +0.2%    +352    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%    +104  [ = ]       0    .debug_ranges
  +0.0%     +64  [ = ]       0    [section .debug_ranges]
  +0.0%     +40  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%     +32  [ = ]       0    .symtab
  +0.2%     +32  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
+0.0%      +8  [ = ]       0    .debug_aranges
-0.0%    -118  [ = ]       0    .debug_loc
  +0.0%    +108  [ = ]       0    src/modules/ekf2/modules__ekf2_unity.cpp
  -0.0%    -226  [ = ]       0    [section .debug_loc]
-0.5%    -351  [ = ]       0    [Unmapped]
+0.0% +1.47Ki  +0.0%    +352    TOTAL

Updated: 2024-11-28T13:56:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant