Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix load monitoring inconsistency bug #23372

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

stocktonslack
Copy link

Solved Problem

Inconsistency in load monitoring for memory when running on a Linux based system. This bug does not always occur, but I found it when running in an Ubuntu 22.04 incus container. See linked Github issue for more detail.

Fixes #{Github issue ID}
#23361

Solution

Reset the file descriptor back to the beginning of the file, rather than to the end of the file, to continually get new updates.

Changelog Entry

For release notes:

Bug fix of load monitoring inconsistency bug

Test coverage

  • Tested fix in SITL in incus Ubuntu 22.04 container.

Context

Related links, screenshot before/after, video
Before console output:
image

After console output:
image

@stocktonslack
Copy link
Author

stocktonslack commented Jul 9, 2024

I don't think these failed checks are related to my PR. Let me know if there's something I can do to fix them.

@mrpollo mrpollo requested review from dagar and bkueng July 11, 2024 02:55
Copy link
Member

@bkueng bkueng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@bkueng bkueng merged commit 36d89df into PX4:main Jul 22, 2024
86 of 90 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants