Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute local rank grid with lazy_grid #85

Merged
merged 46 commits into from
Jan 10, 2024
Merged

Compute local rank grid with lazy_grid #85

merged 46 commits into from
Jan 10, 2024

Conversation

albert-de-montserrat
Copy link
Collaborator

No description provided.

@boriskaus
Copy link
Collaborator

lazy_grid and friends are routines that are useful also outside JustRelax. Would it make sense to put that in a different package (e.g., CompGrids)?

@albert-de-montserrat
Copy link
Collaborator Author

It would makes sense. What's the state of CompGrids? is it usable or needs a good update/rework?

@boriskaus
Copy link
Collaborator

boriskaus commented Dec 28, 2023

it essentially contains nothing, so adding lazy_grid here as well as the CreateArrays function we discussed on Discord would be a great start.
It would allow us to make GeophysicalModelGenerator compatible with ParallelStencil examples with rather minor changes.

@albert-de-montserrat
Copy link
Collaborator Author

Cool! Once I have everything fully figured out and tested in JR I will see how to move it out with a proper API. CompGrids can be a starting point.

@boriskaus
Copy link
Collaborator

Can heatdiffusion_PT! deal with nonlinearities caused by latent heat?
If yes, it could fully replace the corresponding routine in MagmaThermoKinematics (with the advantage that JustRelax runs with MPI as well).

@albert-de-montserrat
Copy link
Collaborator Author

albert-de-montserrat commented Jan 2, 2024 via email

Copy link
Collaborator

@aelligp aelligp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just some minor typos/suggestions

@albert-de-montserrat albert-de-montserrat merged commit d3d9bc8 into main Jan 10, 2024
7 of 8 checks passed
@albert-de-montserrat albert-de-montserrat deleted the adm/mpi branch April 6, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants