Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shearheating #74

Merged
merged 29 commits into from
Dec 20, 2023
Merged

Shearheating #74

merged 29 commits into from
Dec 20, 2023

Conversation

aelligp
Copy link
Collaborator

@aelligp aelligp commented Dec 11, 2023

  • Implementation of Shearheating

  • updated figures for newest Makie.jl release (resolution -> size)

  • Add Shearheating test by Duretz et al 2014

@aelligp aelligp marked this pull request as ready for review December 20, 2023 08:15
Copy link
Collaborator

@albert-de-montserrat albert-de-montserrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! Do you have a snapshot of the last time step of the benchmark?

src/thermal_diffusion/Shearheating.jl Outdated Show resolved Hide resolved
src/thermal_diffusion/Shearheating.jl Outdated Show resolved Hide resolved
src/thermal_diffusion/Shearheating.jl Outdated Show resolved Hide resolved
@aelligp
Copy link
Collaborator Author

aelligp commented Dec 20, 2023

This is after 100 time steps

100

src/MetaJustRelax.jl Outdated Show resolved Hide resolved
@aelligp aelligp merged commit 6cde5ee into main Dec 20, 2023
4 checks passed
@aelligp aelligp deleted the pa-shearheating branch December 20, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants