Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free surface #68

Merged
merged 56 commits into from
Mar 22, 2024
Merged

Free surface #68

merged 56 commits into from
Mar 22, 2024

Conversation

albert-de-montserrat
Copy link
Collaborator

@albert-de-montserrat albert-de-montserrat commented Nov 21, 2023

Adds free surface stabilization from Gerya, Taras. Introduction to numerical geodynamic modelling. Cambridge University Press, 2019., eq. 8.23

The method was first described in:

FEM:

  • Kaus, B.J.P., Mühlhaus, H., May, D.A., 2010. A stabilization algorithm for geodynamic numerical simulations with a free surface. Physics of the Earth and Planetary Interiors 181, 12–20. https://doi.org/10.1016/j.pepi.2010.04.007

Staggered FD:

  • Duretz, T., May, D.A., Gerya, T.V., Tackley, P.J., 2011. Discretization errors and free surface stabilization in the finite difference and marker-in-cell method for applied geodynamics: A numerical study: Geochem. Geophys. Geosyst. 12, n/a-n/a. https://doi.org/10.1029/2011GC003567

Introduces a breaking change: the time step can no longer be dt=Inf when passed into the Stokes solver

@boriskaus
Copy link
Collaborator

Note that my paper has a Rayleigh-Taylor test that is useful to test the implementation (we do that in LaMEM, for example).

@albert-de-montserrat
Copy link
Collaborator Author

Great thanks! I will add it to the miniapps and CI

@aelligp
Copy link
Collaborator

aelligp commented Dec 20, 2023

  • Add polygon / passive tracers to track free surface

@albert-de-montserrat albert-de-montserrat marked this pull request as draft March 13, 2024 12:50
@albert-de-montserrat
Copy link
Collaborator Author

albert-de-montserrat commented Mar 16, 2024

Not very high resolution but looks correct.

Edit: looks slightly asymetric, will investigate

300

@albert-de-montserrat albert-de-montserrat marked this pull request as ready for review March 22, 2024 13:16
@albert-de-montserrat albert-de-montserrat merged commit ceb660b into main Mar 22, 2024
8 checks passed
@albert-de-montserrat albert-de-montserrat deleted the adm-freesurface branch April 6, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants