Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing arch for MacOS #264

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Fix testing arch for MacOS #264

merged 5 commits into from
Oct 17, 2024

Conversation

aelligp
Copy link
Collaborator

@aelligp aelligp commented Oct 17, 2024

This addresses a possible mismatch with the CI infrastructure for macOS-latest as reported by @boriskaus

@aelligp aelligp marked this pull request as ready for review October 17, 2024 08:35
@luraess
Copy link
Member

luraess commented Oct 17, 2024

mac-OS-latest is anyway now testing on aarch64 M-serie chips. Why do you need to have special handling for it still @aelligp ?

@boriskaus
Copy link
Collaborator

It was pointed out to me that if we use macOS-latest along with x64 as arch, the system may actually emulate x64 rather than using aarch64

@albert-de-montserrat
Copy link
Collaborator

Well CI on macOS-latest went down from 27 min to <10 mins. Something definitely changed.

@aelligp
Copy link
Collaborator Author

aelligp commented Oct 17, 2024

According to @boriskaus, when you select macOS-latest but also x64 it may actually not run with aarch64 but instead emulate x64. As observed here PETSc.jl

@albert-de-montserrat albert-de-montserrat merged commit 44bcec3 into main Oct 17, 2024
17 of 18 checks passed
@aelligp aelligp deleted the pa-CI branch December 10, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants