Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phase ratio computation on vertices #230

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

albert-de-montserrat
Copy link
Collaborator

No description provided.

@albert-de-montserrat
Copy link
Collaborator Author

CC @tduretz

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/phases/phases.jl 0.00% 34 Missing ⚠️
src/ext/AMDGPU/2D.jl 0.00% 2 Missing ⚠️
src/ext/AMDGPU/3D.jl 0.00% 2 Missing ⚠️
src/ext/CUDA/2D.jl 0.00% 2 Missing ⚠️
src/ext/CUDA/3D.jl 0.00% 2 Missing ⚠️
Additional details and impacted files

📢 Thoughts on this report? Let us know!

@tduretz
Copy link
Collaborator

tduretz commented Sep 6, 2024

At first sight, it looks correct to me. I haven't tried using it in time-dependent problem yet.
It enabled me to design an initial model setup configuration.
image
Would be great to have the functionalities (phase ratios) directly available in JustPic.

@albert-de-montserrat albert-de-montserrat merged commit 659f4e8 into main Sep 12, 2024
12 checks passed
@albert-de-montserrat albert-de-montserrat deleted the adm/phase_vertices branch September 12, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants