Skip to content

Commit

Permalink
hotfix vscode pytest-xdist issues (#87) (#101)
Browse files Browse the repository at this point in the history
Addresses issues caused by #89, mentioned in #87 
by disabling parallel testing for now.

We still test in parallel in the CI.
We still install pytest-xdist.

Any developer not having issues with parallel testing can add "-n auto" 
in their vscode pytest settings as an additional argument to still use parallel test execution.
  • Loading branch information
fzimmermann89 authored Oct 18, 2023
1 parent d64e0b5 commit 7a0efb3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/pytest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: Run PyTest

run: |
pytest --junitxml=pytest.xml --cov-report=term-missing:skip-covered --cov=mrpro | tee pytest-coverage.txt
pytest -n 4 --junitxml=pytest.xml --cov-report=term-missing:skip-covered --cov=mrpro | tee pytest-coverage.txt
- name: Pytest coverage comment
id: coverageComment
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ docs = ["sphinx", "sphinx_rtd_theme"]
[tool.pytest.ini_options]
testpaths = ["tests"]
filterwarnings = ["error"]
addopts = "-n auto"
# addopts = "-n auto" # TODO: debug vscode missing tests if enabled

# MyPy section
[tool.mypy]
Expand Down

0 comments on commit 7a0efb3

Please sign in to comment.