-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove net_wealth from PSID, update data folder, and code formatting in psid_data_setup.py #23
Conversation
I also verified that the script runs. It produced the following files in
I added |
@jdebacker please let me know if you'd like more info on this to decide on merging. |
This script takes PSID data created from psid_download.R and: | ||
1) Creates variables at the "tax filing unit" (equal to family unit in | ||
PSID since there is no info on the filing status chosen). | ||
2) Selects a sample of observations to work with (e.g., dropping very | ||
old, very low income, etc.). | ||
3) Computes a measure of lifetime income and places each household into | ||
a lifetime income percentile group | ||
''' | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the double quotes everywhere a black
thing @MaxGhenis? You're killing me with these :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep will definitely make these separate commits in the future!
@MaxGhenis This is looking good to me. I especially like including those files in the git ignore. I don't think they need to be checked into the repo. |
@MaxGhenis @jdebacker . I think this PR is ready to merge. But I don't understand the "conflicts that must be resolved" above. When I click on |
@MaxGhenis When conflicts are resolved on this branch, I'm very happy to merged this. B/c wealth variables are important and the |
I messed up #15 after getting behind master and accidentally adding a big file, so trying again. This PR:
net_wealth
, which isn't in.RData
(see Add net_wealth to psid_data_setup.py #21).RData
black
The only substantive changes are in line 25 and 148; everything else is code formatting (sorry these aren't in separate commits).