Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve some bugs for cmaps #4

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Solve some bugs for cmaps #4

wants to merge 1 commit into from

Conversation

mkruckow
Copy link
Contributor

  • there was a typo, which missed to call the _param
  • in log10, I suggest to limit us to very small positive numbers to avoid errors raises for 0 or negative values
  • the dynamic range might not be defined, hence I changed it to be a elif and add a new else clause.

Solve some bugs for cmaps
@mkruckow mkruckow requested review from tassos25 and JRGarza December 5, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant