error catch for He-rich stars in RLO onto H-rich stars #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkruckow
reviewed
Nov 1, 2024
mkruckow
reviewed
Nov 1, 2024
mkruckow
approved these changes
Nov 6, 2024
sgossage
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a temporary fix for part of Issue #418. It adds an error catch in the detached step for binaries with an He-rich star in RLO onto an H-rich star, which account for <0.5% of all binaries at solar metallicity. Ideally we would have a grid to model this subpopulation of binaries, but for now we force them to fail with a POSYDON error.
Here is an example of the output for one such binary run with this PR:
