Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General site updates #40

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

General site updates #40

wants to merge 64 commits into from

Conversation

sgossage
Copy link
Contributor

@sgossage sgossage commented Nov 20, 2024

Footnotes

  1. Code, docs, and data have been collated into a card deck on the home page 2 3

  2. Removed "News" tab from the navigator up top

  3. This has been added to the v1.0.4 docs here, still to be added to v2.0.0-pre

fixed a typo in the About blurb
slight update to About blurb, removing text saying that people can access our query database and pop synth web app from the top tabs.
@sgossage
Copy link
Contributor Author

sgossage commented Nov 20, 2024

On the new "Papers" tab, how should we handle the ACM Digital Library links (Teng et al. papers)? The ACM Digital Library does not have a publicly accessible library like NASA ADS does.

Should we highlight the instrument papers there?

@sgossage
Copy link
Contributor Author

Rather than adding a new tab for Data, I've collated the code, docs and data into one page accessed via the Code tab.

We should discuss whether this is preferable.

@astroJeff
Copy link
Contributor

@sgossage what do you need to finish the last two items on your checklist above?

@sgossage
Copy link
Contributor Author

sgossage commented Dec 3, 2024

I got the funding info and I've made updates. This is ready for review now.

I've put in a placeholder image for the carousel item advertising the v2 paper, which is the grid plot, as discussed. Maybe we'll want to tweak it a bit, but I made some simple edits to get it to fit on the page and not disrupt the site much. The NU Viz credits (which are links) have simply had their font size slightly reduced to draw a bit less attention to them, but we were also considering removing the links.

@sgossage sgossage marked this pull request as ready for review December 3, 2024 20:15
@sgossage
Copy link
Contributor Author

sgossage commented Dec 3, 2024

Also to note: I've updated the code/docs available for v1 to v1.0.4 (from v1.0.0)

Should we have older releases (v1.0.0) recorded too? Maybe it doesn't matter much in this case.

The original v1 data set is linked alongside this, but should we have the re-postprocessed data instead or in addition to this? (https://zenodo.org/records/14205146). I suppose this data set is meant for v2 more, so it should be placed alongside v2, rather than v1.

For now I've added a link to the re-postprocessed data alongside the v2 code/docs/data

…nd support and changed navbar code title to get started
@mkruckow
Copy link
Contributor

Nice improvements!

I'd like to point out two things, which still struggle me:

  • The top menu: for a simple menu bar it takes a lot of the vertical space. The reason is that it's height is determined by the POSYDON logo. How about letting the height be determined by the menu text instead and allow the logo to penetrate beyond? In case people don't like the edges this creates, how about making the logo for the web page to have an ellipsoidal background? Additionally, I'd like to differentiate between jumps on the index page from links to a different page, e.g. by sorting, having a symbol. At the moment it isn't clear to me how we decide which items get an extra link at the top and which only have a link further down on the home page.
  • The news: what is our aim of it? Surely something you find after you scroll down to the bottom of the page I'd not call news, it's more like a (b)log now. Beside that now their box is so small that you can barely see more than one entry. Here I'd suggest to increase the height and/or let is go over the full width as the funding section is doing.

@maxbriel
Copy link
Contributor

Hey Seth, Thank you for the updates!
It looks really sleek and I like the home page with the buttons for different versions! A good solution to present the information.

I just had a browse around and I noticed the following few things. I am using Firefox on MacOS:

  1. The POSYDON v1/v2 panel:
  • The action buttons don't wrap for "Code Repository" and "Zenodo" these go out of the item box.
  • Similarly, the "Zenodo" and "ADS" header images go outside the box.
    This might be solved with a fixed width and having the layout adapt to the page width.
    Additionally, if the sizing of the webpage becomes too small (but far from unreasonable) titles start to wrap the title "Documentation". Is it possible to set a minimum width and have the card wrap/reorder?
    Could bootstrap help with this?
  1. The index page renders larger than the window, adding a horizontal scroll. I believe this is due to a margin or width being added somewhere, but I cannot easily find it. Or some "overflow" setting.

  2. index.html still contains some commented-out items.

  3. The link to POSYDON v2 documentation links to the POSYDON website instead of the current documentation. I cannot switch from the current documentation to the old one using the built-in documentation switcher. (although the other way v1.0.4 -> v2.0-pre1 does work!)
    I saw there were some questions as well about documentation and automatic generation. It should be possible to automatically generate new documentation for each release and have it added to the changing docs in the bottom left.

  4. Are the "Access source code" releases automatically added or is that manual? Can you link to the specific release tag?
    v1.0.0: https://github.com/POSYDON-code/POSYDON/tree/v1.0.0
    v1.0.4: https://github.com/POSYDON-code/POSYDON/tree/v1.0.4
    v2.0.0-pre1: https://github.com/POSYDON-code/POSYDON/tree/v2.0.0-pre1

  5. Team page. The core developers are not "in-column" with one another. They're slightly offset between the two rows in the code, but it doesn't render nicely.

  6. team page: some pictures have the wrong aspect ratio and are transformed to 125x125px, causing them to be distorted, examples in decreasing order of affected: Camille, Elizabeth, Konstantinos, Devina, Zepei
    Additionally, some pictures have very high resolution (beyond what's necessary to look nice) example: Max & Manos

  7. Team page: Monica & Manos picture scale: all other pictures are 125x125, these are 130x125.

  8. leadership. Vicky and Aggelos are offset compared to Jeff and Tassos. Different spacing between then due to col-half-offset.

  9. Team page:

  • LinkedIn redirects to Simone's profile which does not exist. (typo in URL?)
  • Tassosfragos.com links to a weird website.
  1. Is it possible to get some sort of documentation link back in the top header?

  2. Navbar font size changes with the width of the page. This gets really small before reaching the navbar-collapse boundary. Can you fix the font-size for the header?

  3. Similarly, The carousel text gets very small when going to a small width page.

  4. The tutorial links go to the current website is it possible to make it a relative link, instead of an absolute one to make sure it loads the "latest" version?

  5. The alignment of the elements on the left-column on the index.html page is off between "community & support" and "News".

</a>
</div>

<div class="container-fluid p-4" style="margin: 50px 5px;">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This horizontal margin here causes the horizontal scroll bar, which @maxbriel pointed out as 2.

<p></p>
<h5><a href="https://www.linkedin.com/in/elizabeth-teng/" target="_blank" style="color: rgb(0,0,0)">Elizabeth Teng</a></h5>
<p class="card-text">Northwestern University</p>
</div>
</div>

</div>

<br>

<h2 style="text-align:center">PAST CORE DEVELOPERS</h2>
<hr/>

<div class="row">
<div class="col-md align-top col-half-offset">
Copy link
Contributor

@mkruckow mkruckow Jan 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to set the columns manually? Wouldn't it be better to put all into a multicolumn list? This would avoid misplacements in the future as we currently have: having in the last row only one person in the third column.

<ul style="columns: 4;list-style-type: none;">
    <li><a href="https://ch.linkedin.com/in/ssbvr" target="_blank" style="color: rgb(0,0,0)">Simone Bavera </a><\li>
    <li><a href="https://www.it.northwestern.edu/departments/it-services-support/research/staff/coughlin.html" target="_blank" style="color: rgb(0,0,0)">Scott Coughlin </a><\li>
    ...
    <li><a href="https://www.ia.forth.gr/people/zapartas" target="_blank" style="color: rgb(0,0,0)">Manos Zapartas</a><\li>
<\ul>

The same for the past collaboration members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants