Use a flag to track updates/deletes in SQL visitor #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a small refactor we did to remove guesswork. Especially
collector.value.include?(' UPDATE ')
is prone to false positives, for example if you're working with an error column that logs query info, likeSELECT * FROM errors WHERE message ILIKE '%query failed: UPDATE table%'
. It also just felt weird to read from the collector to try to figure out what to do next.