Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a flag to track updates/deletes in SQL visitor #188

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

leboshi
Copy link
Contributor

@leboshi leboshi commented Dec 10, 2024

This was a small refactor we did to remove guesswork. Especially collector.value.include?(' UPDATE ') is prone to false positives, for example if you're working with an error column that logs query info, like SELECT * FROM errors WHERE message ILIKE '%query failed: UPDATE table%'. It also just felt weird to read from the collector to try to figure out what to do next.

@PNixx PNixx merged commit 72504fe into PNixx:master Dec 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants