Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] DAggerValue, ppo_buffer adds next_obs instead of current_obs #3

Open
Phimos opened this issue Dec 27, 2023 · 0 comments
Open

Comments

@Phimos
Copy link

Phimos commented Dec 27, 2023

# Record the transition
self.storage.add_transitions(current_obs, actions_expert, rews, dones)
current_obs.copy_(next_obs)

# value_net
if self.apply_value_net:
    self.ppo_buffer.add_transitions(
        current_obs, current_states, actions, rews, 
        dones, values, actions_log_prob, mu, sigma,
    )
    current_states.copy_(next_states)

the current_obs variable updates before adding transitions to ppo_buffer, so the ppo_buffer actually adds the next_obs instead the current_obs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant