Prevented fatal errors when opening corrupt files or "doc" files #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm looking into the coding standard failures. |
|
I think we're good to go now (guessing the |
everaldofilho
approved these changes
Jul 8, 2024
|
@everaldofilho, thanks for the approval. Any idea when this might get merged? If there are any further changes you'd like me to make, please ask. |
|
@mmcev106 Could you update the changelog ? |
Progi1984
added
the
Status: Waiting for feedback
|
@Progi1984, the changelog has been updated. |
Progi1984
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This prevents fatal exceptions when trying to load corrupt files or old "doc" files, allowing applications to catch the exception and fail gracefully.
Fixes # (issue) - None. I just fixed it without reporting an issue.
Checklist: