Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more PHP versions to the CI and bump actions #49

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Add more PHP versions to the CI and bump actions #49

merged 5 commits into from
Sep 18, 2023

Conversation

williamdes
Copy link
Contributor

No description provided.

@williamdes
Copy link
Contributor Author

I am not sure why there is no CI overview here, but here is the result: https://github.com/williamdes/Invoker/actions/runs/6120452457/job/16612348096

PHP >= 8.1

There was 1 error:

1) Invoker\Test\InvokerTest::should_invoke_callable_with_optional_parameter_before_required_parameter
Invoker\Exception\NotEnoughParametersException: Unable to invoke the callable because no value was given for parameter 1 ($baz)

/home/runner/work/Invoker/Invoker/src/Invoker.php:67
/home/runner/work/Invoker/Invoker/tests/InvokerTest.php:[22](https://github.com/williamdes/Invoker/actions/runs/6120452457/job/16612348312#step:6:23)3

@williamdes
Copy link
Contributor Author

Seems like the fix for PHP-DI/PHP-DI#562 does not work anymore.
Could you have a look @mnapoli ?
I am not sure to be able to fix it.
Checked the test and it looks okay

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@mnapoli
Copy link
Member

mnapoli commented Sep 12, 2023

CI should run again! With another commit we should have build statuses

@williamdes
Copy link
Contributor Author

CI should run again! With another commit we should have build statuses

It did run, now we have the failure as expected 🎉
Can this be merged even with the CI failure ?

@mnapoli mnapoli merged commit fc00418 into PHP-DI:master Sep 18, 2023
5 of 8 checks passed
@williamdes williamdes deleted the patch-2 branch September 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants