Adds GTensor.where function to gtensor and unit tests. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iislucas
reviewed
Jan 23, 2025
| ['pos', 'repSize'], | ||
| ); | ||
|
|
||
| const condition = tf.tensor([1, 0, 0, 1, 1, 0], [3, 2], 'bool'); |
There was a problem hiding this comment.
When you define a 3,2 matrix, best to format it as such to avoid reader having to reflow the tensor. :)
| const g1bigLikeG2 = g1big.transposeLike(g2big); | ||
|
|
||
| const shape = Object.values(g1bigLikeG2.gshape()) as number[]; | ||
| const conditionBig = condition.broadcastTo(shape); |
There was a problem hiding this comment.
There's an issue here: the condition should be a named Tensor, that way we know how it will be broadcast. Otherwise depending on ordering of dimensions, the broadcast result will be different.
I think conceptually what one wants from a named tensor where is that G and G2 intersect, and where intersects with that intersection; that way you know what will broadcast and how it will look over the different dimensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GTensor.where function to gtensor library and unit tests.
As in tf.where function, it returns the elements either of the gtensor or g2 depending on the condition provided.
If the condition is true, it selects the element from the gtensor, otherwise selects from g2.
If the dimensions of the gtensor are different from those of g2, substracted dimensions are broadcasted.