Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oztechan/CCC#4087] Move exact height calculation into AdManager #4088

Merged

Conversation

mustafaozhan
Copy link
Member

Resolves #4087

@mustafaozhan mustafaozhan requested a review from a team as a code owner November 24, 2024 11:54
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 069cec01 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (069cec0) Report Missing Report Missing Report Missing
Head commit (accf3fe) 3246 1734 53.42%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4088) 11 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 56.41%. Comparing base (069cec0) to head (accf3fe).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...echan/ccc/android/ui/mobile/util/ViewExtensions.kt 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4088      +/-   ##
===========================================
- Coverage    56.44%   56.41%   -0.04%     
===========================================
  Files          167      167              
  Lines         3019     3021       +2     
  Branches       437      437              
===========================================
  Hits          1704     1704              
- Misses        1290     1292       +2     
  Partials        25       25              

Impacted file tree graph

Files with missing lines Coverage Δ
...echan/ccc/android/ui/mobile/util/ViewExtensions.kt 0.00% <0.00%> (ø)
---- 🚨 Try these New Features:

@mustafaozhan mustafaozhan merged commit 423611b into develop Nov 24, 2024
15 checks passed
@mustafaozhan mustafaozhan deleted the 4087-Move-exact-height-calculation-into-AdManager branch November 24, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move exact height calculation into AdManager
1 participant