Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oztechan/CCC#4083] Remove onAdLoaded listener and use predefined fixed height #4084

Conversation

mustafaozhan
Copy link
Member

Resolves #4083

@mustafaozhan mustafaozhan requested a review from a team as a code owner November 24, 2024 11:27
@mustafaozhan mustafaozhan force-pushed the 4083-Remove-onAdLoaded-listener-and-use-predefined-fixed-height branch from febf784 to cad04e3 Compare November 24, 2024 11:28
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.18% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8b2e1df) 3251 1734 53.34%
Head commit (cad04e3) 3240 (-11) 1734 (+0) 53.52% (+0.18%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4084) 24 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Nov 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 56.46%. Comparing base (8b2e1df) to head (cad04e3).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...echan/ccc/android/ui/mobile/util/ViewExtensions.kt 0.00% 5 Missing ⚠️
...ui/mobile/content/calculator/CalculatorFragment.kt 0.00% 1 Missing ⚠️
...ui/mobile/content/currencies/CurrenciesFragment.kt 0.00% 1 Missing ⚠️
...oid/ui/mobile/content/settings/SettingsFragment.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4084      +/-   ##
===========================================
+ Coverage    56.26%   56.46%   +0.21%     
===========================================
  Files          167      167              
  Lines         3029     3018      -11     
  Branches       438      437       -1     
===========================================
  Hits          1704     1704              
+ Misses        1300     1289      -11     
  Partials        25       25              

Impacted file tree graph

Files with missing lines Coverage Δ
...ui/mobile/content/calculator/CalculatorFragment.kt 0.00% <0.00%> (ø)
...ui/mobile/content/currencies/CurrenciesFragment.kt 0.00% <0.00%> (ø)
...oid/ui/mobile/content/settings/SettingsFragment.kt 0.00% <0.00%> (ø)
...echan/ccc/android/ui/mobile/util/ViewExtensions.kt 0.00% <0.00%> (ø)
---- 🚨 Try these New Features:

@mustafaozhan mustafaozhan merged commit 266e0f6 into develop Nov 24, 2024
12 checks passed
@mustafaozhan mustafaozhan deleted the 4083-Remove-onAdLoaded-listener-and-use-predefined-fixed-height branch November 24, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove onAdLoaded listener and use predefined fixed height
1 participant