Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oztechan/CCC#3870] Remove CurrenciesFragment navigation result logic #3874

Merged

Conversation

mustafaozhan
Copy link
Member

Resolves #3870

@mustafaozhan mustafaozhan requested a review from a team as a code owner September 8, 2024 16:02
@mustafaozhan mustafaozhan changed the base branch from develop to 3869-Remove-SelectCurrencyFragment-navigation-result-logic September 8, 2024 16:06
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.13% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (45496d6) 3240 1718 53.02%
Head commit (284bfe9) 3232 (-8) 1718 (+0) 53.16% (+0.13%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3874) 2 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.05% 0.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (bdf6dcd) 3235 1718 53.11%
Head commit (284bfe9) 3232 (-3) 1718 (+0) 53.16% (+0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3874) 1 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 56.77%. Comparing base (45496d6) to head (284bfe9).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...ui/mobile/content/currencies/CurrenciesFragment.kt 0.00% 1 Missing ⚠️
...ontent/selectcurrency/SelectCurrencyBottomSheet.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3874      +/-   ##
===========================================
+ Coverage    56.61%   56.77%   +0.16%     
===========================================
  Files          166      166              
  Lines         2920     2912       -8     
  Branches       437      437              
===========================================
  Hits          1653     1653              
+ Misses        1243     1235       -8     
  Partials        24       24              

Impacted file tree graph

Files with missing lines Coverage Δ
...ui/mobile/content/currencies/CurrenciesFragment.kt 0.00% <0.00%> (ø)
...ontent/selectcurrency/SelectCurrencyBottomSheet.kt 0.00% <0.00%> (ø)

Copy link

sonarqubecloud bot commented Sep 8, 2024

Base automatically changed from 3869-Remove-SelectCurrencyFragment-navigation-result-logic to develop September 8, 2024 16:20
@mustafaozhan mustafaozhan merged commit de19ad5 into develop Sep 8, 2024
15 checks passed
@mustafaozhan mustafaozhan deleted the 3870-Remove-CurrenciesFragment-navigation-result-logic branch September 8, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove CurrenciesFragment navigation result logic
1 participant