Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oztechan/CCC#3592] Use the currentBase stored in preference at onResume #3594

Conversation

mustafaozhan
Copy link
Member

Resolves #3592

@mustafaozhan mustafaozhan requested a review from a team as a code owner June 24, 2024 18:56
Copy link

codacy-production bot commented Jun 24, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% 66.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (298b31c) 3275 1704 52.03%
Head commit (8fa1b41) 3277 (+2) 1705 (+1) 52.03% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3594) 3 2 66.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

codecov bot commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.31%. Comparing base (54ea1ee) to head (8fa1b41).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3594      +/-   ##
===========================================
- Coverage    55.31%   55.31%   -0.00%     
===========================================
  Files          166      166              
  Lines         2947     2949       +2     
  Branches       430      431       +1     
===========================================
+ Hits          1630     1631       +1     
- Misses        1293     1294       +1     
  Partials        24       24              

Impacted file tree graph

Files Coverage Δ
.../ccc/client/viewmodel/calculator/CalculatorSEED.kt 100.00% <ø> (ø)
...client/viewmodel/calculator/CalculatorViewModel.kt 99.35% <100.00%> (+<0.01%) ⬆️
...ui/mobile/content/calculator/CalculatorFragment.kt 0.00% <0.00%> (ø)

@mustafaozhan mustafaozhan force-pushed the 3592-Use-the-currentBase-stored-in-preference-at-onResume branch 2 times, most recently from 7195e88 to 25170c4 Compare June 26, 2024 07:16
@mustafaozhan mustafaozhan force-pushed the 3592-Use-the-currentBase-stored-in-preference-at-onResume branch from 25170c4 to 8fa1b41 Compare June 30, 2024 09:13
Copy link

@mustafaozhan mustafaozhan merged commit 583c415 into develop Jun 30, 2024
14 checks passed
@mustafaozhan mustafaozhan deleted the 3592-Use-the-currentBase-stored-in-preference-at-onResume branch June 30, 2024 10:01
mustafaozhan added a commit that referenced this pull request Jun 30, 2024
* Revert "[#3591] Remove set and get navigation results (#3596)"

This reverts commit 8ef9402.

* Revert "[#3590] Remove CalculatorFragment navigation result logic (#3595)"

This reverts commit 8995aa1.

* Revert "[#3587] Remove CurrenciesFragment navigation result logic (#3589)"

This reverts commit eee3c4b.

* Revert "[#3585] Remove SelectCurrencyFragment navigation result logic (#3586)"

This reverts commit 6a46d24.

* Revert "[#3592] Use the currentBase stored in preference at onResume (#3594)"

This reverts commit 583c415.

* [#3638] Add back navigation result logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the currentBase stored in preference at onResume
1 participant