Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Oztechan/CCC#1717] Remove dependency updates library #1718

Merged
merged 4 commits into from
Jan 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions build.gradle.kts
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
/*
* Copyright (c) 2020 Mustafa Ozhan. All rights reserved.
*/
import com.github.benmanes.gradle.versions.updates.DependencyUpdatesTask
import io.gitlab.arturbosch.detekt.Detekt
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile

plugins {
@Suppress("DSL_SCOPE_VIOLATION")
libs.plugins.apply {
alias(dependencyUpdates)
alias(kover)
alias(detekt)
alias(sonarqube)
Expand Down Expand Up @@ -92,8 +90,3 @@ allprojects {
}
}
}

tasks.withType<DependencyUpdatesTask> {
gradleReleaseChannel = "current"
rejectVersionIf { candidate.version.isNonStable() }
}
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import org.gradle.api.Project
import java.io.IOException
import java.util.Locale
import java.util.Properties

private const val PATH_SECRET_PROPERTIES = "../secret.properties"
Expand All @@ -22,17 +21,3 @@ private fun Project.getSecretProperties() = try {
logger.debug(e.message, e)
null
}

fun String.isNonStable(): Boolean {
val stableKeyword = listOf(
"RELEASE",
"FINAL",
"GA"
).any {
this.toUpperCase(Locale.ROOT).contains(it)
}

val regex = "^[0-9,.v-]+(-r)?$".toRegex()
val isStable = stableKeyword || regex.matches(this)
return isStable.not()
}
2 changes: 0 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ leakCanary = "2.10"
sqlDelight = "1.5.4"
lifecycle = "2.5.1"
mokoResources = "0.20.1"
dependencyUpdates = "0.44.0"
buildKonfig = "0.13.3"
workRuntime = "2.7.1"
splashScreen = "1.0.0"
Expand Down Expand Up @@ -140,7 +139,6 @@ firebasePerPlugin = { id = "com.google.firebase.firebase-perf" }
kotlinXSerialization = { id = "kotlinx-serialization" }
sqlDelight = { id = "com.squareup.sqldelight" }
mokoResources = { id = "dev.icerock.mobile.multiplatform-resources" }
dependencyUpdates = { id = "com.github.ben-manes.versions", version.ref = "dependencyUpdates" }
kover = { id = "org.jetbrains.kotlinx.kover", version.ref = "kover" }
ksp = { id = "com.google.devtools.ksp", version.ref = "ksp" }
detekt = { id = "io.gitlab.arturbosch.detekt", version.ref = "detekt" }
Expand Down
2 changes: 1 addition & 1 deletion submodule/basemob
2 changes: 1 addition & 1 deletion submodule/logmob
2 changes: 1 addition & 1 deletion submodule/parsermob
2 changes: 1 addition & 1 deletion submodule/scopemob