Skip to content

Commit

Permalink
[#2929] Get rid of firebasePerPlugin classpath
Browse files Browse the repository at this point in the history
  • Loading branch information
mustafaozhan committed Oct 27, 2023
1 parent b1faebb commit 5d288af
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 4 deletions.
1 change: 0 additions & 1 deletion CCC.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ buildscript {
libs.classpaths.apply {
classpath(androidGradlePlugin)
classpath(kotlinGradlePlugin)
classpath(firebasePerPlugin)
classpath(navigation) // todo can be removed once compose migration done
classpath(mokoResources)
classpath(buildKonfig)
Expand Down
2 changes: 1 addition & 1 deletion android/app/android-app.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ import config.key.secret
plugins {
libs.plugins.apply {
alias(androidApplication)
id(firebasePerPlugin.get().pluginId)
alias(kotlinAndroid)
alias(googleServices)
alias(firebaseCrashlytics)
alias(firebasePerPlugin)
}
}

Expand Down
3 changes: 1 addition & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,6 @@ processors-mockative = { module = "io.mockative:mockative-processor", version.re
# CLASSPATHS
classpaths-androidGradlePlugin = { module = "com.android.tools.build:gradle", version.ref = "androidGradlePlugin" }
classpaths-kotlinGradlePlugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
classpaths-firebasePerPlugin = { module = "com.google.firebase:perf-plugin", version.ref = "firebasePerPlugin" }
classpaths-navigation = { module = "androidx.navigation:navigation-safe-args-gradle-plugin", version.ref = "navigation" }
classpaths-mokoResources = { module = "dev.icerock.moko:resources-generator", version.ref = "mokoResources" }
classpaths-buildKonfig = { module = "com.codingfeline.buildkonfig:buildkonfig-gradle-plugin", version.ref = "buildKonfig" }
Expand All @@ -137,7 +136,7 @@ safeArgs = { id = "androidx.navigation.safeargs" }
buildKonfig = { id = "com.codingfeline.buildkonfig" }
firebaseCrashlytics = { id = "com.google.firebase.crashlytics", version.ref = "firebaseCrashlytics" }
googleServices = { id = "com.google.gms.google-services", version.ref = "googleServices" }
firebasePerPlugin = { id = "com.google.firebase.firebase-perf" }
firebasePerPlugin = { id = "com.google.firebase.firebase-perf", version.ref = "firebasePerPlugin" }
sqlDelight = { id = "com.squareup.sqldelight", version.ref = "sqlDelight" }
mokoResources = { id = "dev.icerock.mobile.multiplatform-resources" }
serialization = { id = "org.jetbrains.kotlin.plugin.serialization", version.ref = "kotlin" }
Expand Down

0 comments on commit 5d288af

Please sign in to comment.