Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ERST: Tomcat relative oxalis home #625

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nemhandel4erst
Copy link

@nemhandel4erst nemhandel4erst commented Jun 6, 2023

Pull Request Description

Erhvervsstyrelsen (ERST) has implemented a Tomcat relative property home detector. It takes a property RELATIVE_OXALIS_HOME and detects that path relative to the Tomcat catalina.base property.

This is very useful for us because we place the oxalis home folder in the same location within the Tomcat folder. The absolute path to the Tomcat folder may vary across different environments or on developers' computers, making it inconsistent.

See change here:
https://rep.erst.dk/git/openebusiness/nemhandeledelivery/oxalis/-/blob/master/oxalis-commons/src/main/java/dk/erst/oxalis/commons/filesystem/detector/RelativePropertyHomeDetector.java

Type of Pull Request

  • New feature/Enhancement - non-breaking change which adds functionality
  • Bug fix
  • Breaking change (Require Major version change?)

Type of Change

  • OpenPeppol AS2/AS4 specification
  • OpenPeppol Spring/Fall release
  • Oxalis software change or enhancement
  • CEF change

Pull Request Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas. But did not added unnecessary annotation/comment say @author name etc
  • I have checked my code for variable and method name and corrected grammar/spelling mistakes if any
  • I have made corresponding changes to the documentation where needed
  • My changes generate no new/additional warnings
  • My change is not breaking or creating conflict with associated dependencies
  • I have performed a self-review of my own code
  • I ran mvn clean install before commit and all tests run successfully
  • I conducted basic QA to assure all features are working fine
  • My pull request generate no conflicts with master branch
  • I requested code review from other team members

@nemhandel4erst nemhandel4erst marked this pull request as ready for review June 6, 2023 11:11
@dladlk dladlk requested a review from aaron-kumar June 6, 2023 14:04
@dladlk
Copy link

dladlk commented Jun 6, 2023

As you maybe noticed, 2 other changes in Oxalis I have already copied from ERST code base - described in the task #623 and OxalisCommunity/Oxalis-AS4#206 with linked pull requests.
This change I evaluated and found out, that it can reside in the nemhandel "extension" - so it is not critical to include it into the main code base.
But I requested @aaron-kumar to review this change request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants