Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DK ERST Nemhandel eDelivery: Expand transport profiles detection with a filtering by modes #623

Closed
dladlk opened this issue May 24, 2023 · 2 comments · May be fixed by #624
Closed

DK ERST Nemhandel eDelivery: Expand transport profiles detection with a filtering by modes #623

dladlk opened this issue May 24, 2023 · 2 comments · May be fixed by #624

Comments

@dladlk
Copy link

dladlk commented May 24, 2023

In May 2023 Danish digitization organization ERST released a first version of the Oxalis customization, modified to be used as a reference implementation of the new Nemhandel standard, based on eDelivery and AS4.
It supposes to use a custom transport profile and custom certification authority (MitID-based).
In the reference implementation it is done so that Oxalis on the start basing on configured certificate can detect, that it works in "NEMHANDEL" mode - and use another transport profile for lookups.
But this change was implemented in a "forked" version of Oxalis only - although it looks like it has sense to integrate it to mainstream branch here e.g. to avoid future needs to introduce FRTEST modes to be hardcoded in Mode.java of peppol-mode project.

The change is very simple and local - also as covered by unit tests, implemented by ERST in their Oxalis copy.

Modified classes:
https://rep.erst.dk/git/openebusiness/nemhandeledelivery/oxalis/-/blob/51b4dff8b9ed9d69d72b3ecbbcaf5aaf846eafcb/oxalis-outbound/src/main/java/network/oxalis/outbound/transmission/MessageSenderFactory.java#L79

https://rep.erst.dk/git/openebusiness/nemhandeledelivery/oxalis/-/blob/51b4dff8b9ed9d69d72b3ecbbcaf5aaf846eafcb/oxalis-outbound/src/test/java/network/oxalis/outbound/transmission/MessageSenderFactoryTest.java#L59

Example of configuration can be found in modified reference.conf in tests.

All what is changed - it is possible to configure list of modes on transport definition:

defaults.transport.foo_mode_transport = {
    profile: foo-mode-transport
    sender: invalid
    weight: 0
    modes: [foo, foo_test]
}

defaults.transport.dummy_mode_transport = {
    profile: dummy-mode-transport
    sender: invalid
    weight: -1
    modes: [DUMMY]
}

There are several other changes in ERST Oxalis, which have sense to incorporate into main Oxalis branch.

@dladlk dladlk linked a pull request May 24, 2023 that will close this issue
18 tasks
@dladlk dladlk changed the title Expand transport profiles detection with a filtering by modes DK ERST Nemhandel eDelivery: Expand transport profiles detection with a filtering by modes May 24, 2023
@dladlk
Copy link
Author

dladlk commented May 24, 2023

Other DK ERST Nemhandel eDelivery related ticket: OxalisCommunity/Oxalis-AS4#206

@aaron-kumar
Copy link
Member

Closing this as it will taken care of as part of EPIC: OxalisCommunity/Oxalis-Public-Roadmap#23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants