Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for C1CountryIdentifier (COUNTRY_C1) not set in As4PayloadHeader … #218

Merged
merged 1 commit into from
Oct 8, 2023

Conversation

seciq
Copy link

@seciq seciq commented Oct 6, 2023

#217

Pull Request Description

Adds getter and setter in the As4PayloadHeader class for c1CountryIdentifier. This is required to fetch the COUNTRY_C1 from the header object for TSR/EUSR statistics reporting.

Type of Pull Request

  • New feature/Enhancement - non-breaking change which adds functionality
  • Bug fix
  • Breaking change (Require Major version change?)

Type of Change

  • OpenPeppol AS4 specification
  • Oxalis software change or enhancement
  • CEF change

Pull Request Checklist:

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas. But did not added unnecessary annotation/comment say @author name etc
  • I have checked my code for variable and method name and corrected grammar/spelling mistakes if any
  • I have made corresponding changes to the documentation where needed
  • My changes generate no new/additional warnings
  • My change is not breaking or creating conflict with associated dependencies
  • I have performed a self-review of my own code
  • I ran mvn clean install before commit and all tests run successfully
  • I conducted basic QA to assure all features are working fine
  • My pull request generate no conflicts with master branch
  • I requested code review from other team members

Copy link

@dladlk dladlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without overriding getC1CountryIdentifier() with a call to a delegate header, the method always returns null. Looks like an urgent fix.

@aaron-kumar aaron-kumar merged commit a331236 into OxalisCommunity:master Oct 8, 2023
@aaron-kumar
Copy link
Member

Thanks for your contribution @seciq .
This fix will be part of upcoming Oxalis/Oxalis-AS4 release (tentative schedule on 15.10.2023)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants