Updates from upstream + MABS compatibility #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the `Attribute activity#com.facebook.FacebookActivity@theme` error
Its better to just remove android:theme="@android:style/Theme.Translucent.NoTitleBar" from the <activity> xml tag since the latest Facebook SDK 4.16.1 already includes it.
source: http://stackoverflow.com/a/39786339/1211174
Document ios10 login issue
upgrade to the last facebook sdk + a fix
README: Updated outdated link to repo/docs
Avoid FB prompt if required permission declined
Added function in iOS to check if a passed array of permissions have been granted
* Added hashtag support * Typo fix * Misplaced the command earlier -- rather than typo * Added hashtag for share dialog options example
Not returning boolean in application:openURL has an undefined behaviour.
* Updated logPurchase to handle decimal values correctly. * Updated logPurchase to handle decimal values correctly.
* Update facebook-browser.js * Commens and improvement on FB.login functon Added comments and improved logic to check for response first then or response.status.
* Update FacebookSDKs-iOS-4.31.1 * contentTitle, imageURL and contentDescription have been deprecated in Facebook API 2.9 * Update README according deprecation
* Update FacebookConnectPlugin.m Fix jeduan#750 * Update README.md * Upgraded facebook sdk to 5.0.2 * Fix calls to deprecated facebook sdk functions on android which caused runtime crash when called. * Removing Bolts framework ios dependency which is not used in ios sdk v5 facebook/facebook-ios-sdk@0bdd850 * Modernized FBSDKLoginKit usage according to facebook/facebook-ios-sdk@6c4ac12 facebook/facebook-ios-sdk@5eae2d7: 1. Replaced FBSDKLoginManagerRequestTokenHandler by FBSDKLoginManagerLoginResultBlock 2. Replaced logInWithReadPermissions and logInWithPublishPermissions by logInWithPermissions Modernized FBSDKShareKit usage according to facebook/facebook-ios-sdk@9b682bb: 1. Updated FBSDKShareOpenGraphAction init to actionWithType 2. Replaced FBSDKGraphRequestHandler by FBSDKGraphRequestBlock * removed irrelevant files
* Bump iOS SDK version to 5.6.0 * Bump Android SDK version to 5.5.1
update pods
When an access token is expired this plugin would not fetch a new one. This is invalid behaviour and resulted in failed login attempts because the token was expired, but still passed to the javascript code as a valid token. This patch adds a check if the token is expired as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update to the latest from upstream.
Mabs compatibility: