Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-11521: the behavior of "ActiveSubMenu" differs in the OutSystems UI different versions #1009

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

JoaoFerreira-FrontEnd
Copy link
Contributor

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd commented Jan 8, 2025

This PR is for fixing a bug on the Menu utils client action ("SetActiveMenuItems").

What was happening

  • The code was prepared to select the active item based on its index inside the parent, however since we implemented the focus trap, the submenu has more children that are not submenu items.
  • Because of this I changed the selector to be stronger than just the child index.

What was done

  • Get Active SubItem using a strong selector pointing to the specific sub-items instead of the children list;

Test Steps

  1. Go to sample
  2. On Page Ready fill the input with an index that exists inside the submenu

Checklist

  • tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd added the bug Something isn't working label Jan 8, 2025
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd requested a review from a team as a code owner January 8, 2025 19:08
Copy link

sonarqubecloud bot commented Jan 8, 2025

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd merged commit 97f64c6 into dev Jan 9, 2025
10 checks passed
@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd deleted the ROU-11521 branch January 9, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants