Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROU-11343: Fixed patterns and widgets issues when high contrast mode enabled. #1002

Merged
merged 50 commits into from
Nov 27, 2024
Merged

ROU-11343: Fixed patterns and widgets issues when high contrast mode enabled. #1002

merged 50 commits into from
Nov 27, 2024

Conversation

joselrio
Copy link
Contributor

This PR is will :

  • Add the ability to OutSystemsUI library be able to understand if user is using (through operating system) dark-mode and/or high-contrast mode. According it a new class will be added to the body os-dark-mode and/or os-high-contrast.
  • Fix styling issues at patterns and widgets when high contrast mode is enabled.

NOTE:

  • Under this context nothing has been done to support dark-mode themes for now, but the class is there to be used if it's the case.

@joselrio
Added highContrast and darkMode detection and body classes accordingly.
739127d
@joselrio
Updated file comments.
9c6b1d8
@joselrio
Improved comments.
52ba846
@joselrio
Apply consistency to the event type.
6915d02
@joselrio
Updated classNames to be clear they will be natively detected.
8dc0674
@joselrio
Clarify to system to avoid confusion with native/mobile
03b195c
@joselrio
Rollback to the initial name :/
dfc73f5
@joselrio
Update GlobalEnum.ts
4e44e33
@joselrio
Update naming
3a23b5f
@joselrio
Redefine the outline when operating system high contrast is on.
3e0294b
@joselrio
Set hight contrast styling.
8def58f
@joselrio
Turn pagination visible when high-contrast is enabled.
4e5d5ff
@joselrio
Turn selected button visible to high contrast mode.
7f00e9a
@joselrio
Turn visible popup boundaries for high contrast mode.
9adc68f
@joselrio
Turn visible feedback message boundaries to high contrast mode.
bd3685e
@joselrio
Turn spinner visible when hight contrast is enabled.
c6fc479
@joselrio
Turn tooltip boundaries visible to high contrast mode.
5d0d31e
@joselrio
Update font and content to be more universal.
0004008
@joselrio
Turn BottomSheet boundaries visible to high contrast mode.
960279f
@joselrio
Fix visual issues when high contrast mode is on.
b53e485
@joselrio
Removed unused selectors.
85f6b44
@joselrio
Fix visual issues when high contrast mode is on.
82a83bb
@joselrio
Sort properties selectors.
d574602
@joselrio
Fix visual issues when high contrast mode is on.
5c62e26
@joselrio
Turn button visible to high contrast mode.
1a1545b
@joselrio
Fix visual issued at high contrast mode.
c5011b6
@joselrio
Turn progress bar visible to high contrast mode.
3d1c63e
@joselrio
Turn RangeSlider bars visible to high contrast mode.
2684fe8
@joselrio
Fix visual issued at high contrast mode.
572ff0e
@joselrio
Update settings.json
18631b5
@joselrio joselrio requested a review from a team as a code owner November 25, 2024 18:18
BenOsodrac
BenOsodrac requested changes Nov 26, 2024
View reviewed changes
src/scripts/OSFramework/OSUI/Pattern/AnimatedLabel/scss/_animated-label.scss Outdated Show resolved Hide resolved
src/scripts/OSFramework/OSUI/Pattern/AnimatedLabel/scss/_animated-label.scss Outdated Show resolved Hide resolved
src/scripts/OSFramework/OSUI/Pattern/Carousel/scss/_carousel.scss Outdated Show resolved Hide resolved
src/scripts/OSFramework/OSUI/Pattern/DropdownServerSideItem/scss/_dropdownserversideitem.scss Outdated Show resolved Hide resolved
src/scripts/OSFramework/OSUI/Pattern/OverflowMenu/scss/_overflowmenu.scss Outdated Show resolved Hide resolved
src/scss/04-patterns/02-content/_floating-content.scss Outdated Show resolved Hide resolved
src/scss/04-patterns/03-interaction/_action-sheet.scss Outdated Show resolved Hide resolved
src/scss/04-patterns/03-interaction/_action-sheet.scss Outdated Show resolved Hide resolved
src/scss/04-patterns/03-interaction/_action-sheet.scss Outdated Show resolved Hide resolved
src/scss/04-patterns/04-navigation/_pagination.scss Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@joselrio joselrio merged commit 2033a4f into dev Nov 27, 2024
10 of 14 checks passed
@joselrio joselrio deleted the ROU-11343 branch November 27, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OS-giulianasilva OS-giulianasilva OS-giulianasilva approved these changes

@BenOsodrac BenOsodrac BenOsodrac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joselrio @BenOsodrac @OS-giulianasilva