Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ROU-11342]: RadioButton - Fixed styling issue when HighContrast mode is on. #1000

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[ROU-11342]: RadioButton - Fixed styling issue when HighContrast mode is on. #1000

merged 1 commit into from
Nov 4, 2024

Conversation

joselrio
Copy link
Contributor

@joselrio joselrio commented Oct 31, 2024 •
edited
Loading

This PR will fix a styling issue at RadioButton widget.

What was happening

  • When HighContrast mod was on and HasAccessibility features layout attribute was set to True, RadioButton styling was not being set as it should.
  • Only happening at Windows.

What was done

  • Redefined the css selector into a specific selector instead of the usage of a shorthand one.

Screenshots

radioButtonIssue

@joselrio joselrio requested a review from a team as a code owner October 31, 2024 16:35
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@joselrio joselrio added the bug Something isn't working label Oct 31, 2024
@joselrio joselrio merged commit 8a66ac4 into dev Nov 4, 2024
9 checks passed
@joselrio joselrio deleted the ROU-11342 branch November 4, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenOsodrac BenOsodrac BenOsodrac approved these changes

Assignees

@BenOsodrac BenOsodrac

@JoaoFerreira-FrontEnd JoaoFerreira-FrontEnd

@OS-giulianasilva OS-giulianasilva

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joselrio @BenOsodrac @JoaoFerreira-FrontEnd @OS-giulianasilva