-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROU-4709: Fixing cluster problems with back-button, other improvements #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the back button is used, and the previous page has a list records with markers, the markers are first build then destroyed then built again... And when Addresses are passed, what happened was that the FinishBuild was ran after the dispose, causing a glitch in the number of markers per cluster.
gnbm
reviewed
Feb 9, 2024
OS-giulianasilva
previously approved these changes
Feb 12, 2024
JoaoFerreira-FrontEnd
previously approved these changes
Feb 12, 2024
rugoncalves
dismissed stale reviews from JoaoFerreira-FrontEnd and OS-giulianasilva
via
February 14, 2024 13:29
9c249c5
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
JoaoFerreira-FrontEnd
approved these changes
Feb 14, 2024
OS-giulianasilva
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in the continuation of previous PR, which introduced some issues, now solved. Additionally more fixes were added.
What was happening
Google Maps JavaScript API has been loaded directly without loading=async. This can result in suboptimal performance. For best-practice loading patterns please see https://goo.gle/js-api-loading
What was done
_destroyed
to theAbstractMarker
class. This attribute will be set to true when the Marker is disposed, so that if the when thebuild()
is occurring and the address needs to be converted into coordinates, if the Marker is destroyed meanwhile, upon resolving the address promise, no other code is executed.loading=async
in the URL of Google Maps:v=X.xx
that defines the version of Google Maps to be loaded:3.55
will be made stale (or stable) by mid-February 2024;Checklist