ROU-4431: Migrate OS Maps into ODC Maps v1.6.7 #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated asset version to 1.6.6.
…hape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts
… not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- Co-authored-by: OUTSYSTEMS\fmj <[email protected]>
Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet
This reverts commit 96154f3.
Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet
ROU-4361 - Update Images.css
Added CSS class .runtime-staticMap-container-hide
ROU-4469: Update Map.css
ROU-4580: Make the bot commits signed
ROU-4375: Add types to events
ROU-4631: improvements to the types in the code
ROU-4591: change how addresses are transformed into coordenates
ROU-4592: fixing google maps imprecision with markers
|
Kudos, SonarCloud Quality Gate passed!
|
bmarcelino-fe
requested review from
gnbm,
joselrio,
BenOsodrac,
rugoncalves,
JoaoFerreira-FrontEnd and
OS-giulianasilva
as code owners
OS-giulianasilva
approved these changes
Dec 12, 2023
BenOsodrac
approved these changes
Dec 13, 2023
bmarcelino-fe
added a commit
that referenced
this pull request
Dec 14, 2023
* Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- Co-authored-by: OUTSYSTEMS\fmj <[email protected]> * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Update Map.css Added CSS class .runtime-staticMap-container-hide * Update Map.css * Increase Maps version to 1.6.7 * Adding git action * Adding workflow to generate documentation in dev * Changes in workflows * Create main-push.yml * Changing workflow name * Update dev-pr.yml * Moving actions into folder * Chaning workflow to use new folder * Adding types to events * Missing parameter, when not passed structure * Missing parameter * Initial changes * Lint changes * Changing input from value to propertyValue * Improving variable name * Fixing sonarcloud findings * Sonar cloud feedback * More sonarcloud feedback * Changing the way addresses are converted * Removing the apiKey parameter * Adding sonarcloud lint * Fix auto merge problem * Add function to easily check if a number is valid * Explicitly set type of size as number * Validating that height and width are bigger than 0 * Updated Version 1.6.8 and added .snyk file Updated Version 1.6.8 and added .snyk file * ROU-4431: Migrate OS Maps into ODC Maps v1.6.7 (#147) * Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- Co-authored-by: OUTSYSTEMS\fmj <[email protected]> * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Update Map.css Added CSS class .runtime-staticMap-container-hide * Update Map.css * Increase Maps version to 1.6.7 * Adding git action * Adding workflow to generate documentation in dev * Changes in workflows * Create main-push.yml * Changing workflow name * Update dev-pr.yml * Moving actions into folder * Chaning workflow to use new folder * Adding types to events * Missing parameter, when not passed structure * Missing parameter * Initial changes * Lint changes * Changing input from value to propertyValue * Improving variable name * Fixing sonarcloud findings * Sonar cloud feedback * More sonarcloud feedback * Changing the way addresses are converted * Removing the apiKey parameter * Adding sonarcloud lint * Fix auto merge problem * Add function to easily check if a number is valid * Explicitly set type of size as number * Validating that height and width are bigger than 0 * Fix duplicated methods on Circle --------- Co-authored-by: gbnm <[email protected]> Co-authored-by: Giuliana Silva <[email protected]> Co-authored-by: João Ferreira <[email protected]> Co-authored-by: OUTSYSTEMS\fmj <[email protected]> Co-authored-by: rug <[email protected]> --------- Co-authored-by: gbnm <[email protected]> Co-authored-by: Giuliana Silva <[email protected]> Co-authored-by: João Ferreira <[email protected]> Co-authored-by: OUTSYSTEMS\fmj <[email protected]> Co-authored-by: rug <[email protected]>
bmarcelino-fe
added a commit
that referenced
this pull request
Dec 14, 2023
* Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Update Map.css Added CSS class .runtime-staticMap-container-hide * Update Map.css * Increase Maps version to 1.6.7 * Adding git action * Adding workflow to generate documentation in dev * Changes in workflows * Create main-push.yml * Changing workflow name * Update dev-pr.yml * Moving actions into folder * Chaning workflow to use new folder * Adding types to events * Missing parameter, when not passed structure * Missing parameter * Initial changes * Lint changes * Changing input from value to propertyValue * Improving variable name * Fixing sonarcloud findings * Sonar cloud feedback * More sonarcloud feedback * Changing the way addresses are converted * Removing the apiKey parameter * Adding sonarcloud lint * Fix auto merge problem * Add function to easily check if a number is valid * Explicitly set type of size as number * Validating that height and width are bigger than 0 * Updated Version 1.6.8 and added .snyk file Updated Version 1.6.8 and added .snyk file * ROU-4431: Migrate OS Maps into ODC Maps v1.6.7 (#147) * Update asset version to 1.6.6 Updated asset version to 1.6.6. * ROU-4222: DrawCircle AddOn does not pass coordinates when editing a shape (#132) * Fix issue with Leaflet OnDrawingChange event * Remove unnecessary arguments * Fix OnDrawChange event for Google Maps * Remove unnecessary arguments and comments * Add comments * Fix eslint errors * Fix Code smell * Removed repeated code * Add shape types * Update ShapeProviderEvent.ts * ROU-4283 - [OSMaps] - Leaflet and Google Maps - DrawCircle AddOn does not pass coordinates when editing a shape (#133) * - fix coords sended on the coordinates parameter of triggerOnDrawingChangeEvent; * - change the return location on draging end (draw marker); --------- * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Revert "Update Images.css" This reverts commit 96154f3. * Update Images.css Includes the changes made in ROU-4361 in order to replace the base 64 for the CSS vars → --map-container-image-google and --map-container-image-leaflet * Update Map.css Added CSS class .runtime-staticMap-container-hide * Update Map.css * Increase Maps version to 1.6.7 * Adding git action * Adding workflow to generate documentation in dev * Changes in workflows * Create main-push.yml * Changing workflow name * Update dev-pr.yml * Moving actions into folder * Chaning workflow to use new folder * Adding types to events * Missing parameter, when not passed structure * Missing parameter * Initial changes * Lint changes * Changing input from value to propertyValue * Improving variable name * Fixing sonarcloud findings * Sonar cloud feedback * More sonarcloud feedback * Changing the way addresses are converted * Removing the apiKey parameter * Adding sonarcloud lint * Fix auto merge problem * Add function to easily check if a number is valid * Explicitly set type of size as number * Validating that height and width are bigger than 0 * Fix duplicated methods on Circle --------- --------- Co-authored-by: gbnm <[email protected]> Co-authored-by: Giuliana Silva <[email protected]> Co-authored-by: João Ferreira <[email protected]> Co-authored-by: OUTSYSTEMS\fmj <[email protected]> Co-authored-by: rug <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for migration OS Maps into ODC Maps v1.6.7.
Checklist