Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROU-4375: Add types to events #142

Merged
merged 4 commits into from
Oct 30, 2023
Merged

ROU-4375: Add types to events #142

merged 4 commits into from
Oct 30, 2023

Conversation

rugoncalves
Copy link
Contributor

This PR is for missing types to the events of the Maps.

What was happening

  • Previously, some of the events, were accessing to the args in a given position to obtain certain values. This made the code harder to maintain and more error prone.

What was done

  • Added 3 new interfaces:
    • IDrawingToolsEventParams
    • IFileLayerEventParams
    • ISearchPlacesEventParams
  • Created a new input parameter in the trigger action of:
    • DrawingTools
    • FileLayer
    • SearchPlaces
  • Set the interfaces as the type of the invocation of the trigger method

Checklist

  • [x tested locally
  • documented the code
  • clean all warnings and errors of eslint
  • requires changes in OutSystems (if so, provide a module with changes)
  • requires new sample page in OutSystems (if so, provide a module with changes)

BenOsodrac
BenOsodrac previously approved these changes Oct 26, 2023
src/Providers/Maps/Google/SearchPlaces/SearchPlaces.ts Outdated Show resolved Hide resolved
joselrio
joselrio previously approved these changes Oct 26, 2023
@rugoncalves rugoncalves dismissed stale reviews from joselrio and BenOsodrac via 9048e5a October 30, 2023 08:48
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rugoncalves rugoncalves requested a review from joselrio October 30, 2023 09:19
@rugoncalves rugoncalves merged commit a3b6127 into dev Oct 30, 2023
11 checks passed
@rugoncalves rugoncalves deleted the ROU-4375 branch October 30, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants