forked from chemerisuk/cordova-plugin-firebase-analytics
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMET-3608 - Prepare to release version 5.0.0-OS14
#41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oid SDK (#40) * feat: use Firebase Android BOM library to set the version of FB Analytics Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: declare Firebase dependencies in build.gradle file References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * test: use framework to set firebase-analytics version References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * refactor: declare Firebase dependencies in build.gradle file References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: enable Kotlin Context: This is necessary for MABS 9. We currently say that the current version of the plugin works with MABS 9 and MAS 10, but it actually doesn't work with MABS 9 because we use Kotlin code but do not enable the Kotlin plugin. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * test: enable AndroidX * chore: revert previous commit * fix: enable Kotlin Context: This is necessary for MABS 9. We currently say that the current version of the plugin works with MABS 9 and MAS 10, but it actually doesn't work with MABS 9 because we use Kotlin code but do not enable the Kotlin plugin. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: revert previous commit * test: include FB Analytics using framework * test: enable Kotlin * refactor: include FB dependencies in build.gradle References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore: revert previous commit that added Kotlin * chore: update changelog https://outsystemsrd.atlassian.net/browse/RMET-3608
Quality Gate passedIssues Measures |
alexgerardojacinto
changed the title
RMET-3608 FB Analytics - Update dependency to Firebase Analytics Andr…
RMET-3608 - Prepare to release version Sep 17, 2024
5.0.0-OS14
alexgerardojacinto
requested review from
ItsChaceD,
IT-MikeS,
OS-ricardomoreirasilva and
OS-martacarlos
and removed request for
a team
September 17, 2024 11:26
OS-ricardomoreirasilva
approved these changes
Sep 17, 2024
IT-MikeS
approved these changes
Sep 17, 2024
IT-MikeS
added a commit
that referenced
this pull request
Oct 10, 2024
* RMET-3608 - Prepare to release version `5.0.0-OS14` (#41) * RMET-3608 FB Analytics - Update dependency to Firebase Analytics Android SDK (#40) * feat: use Firebase Android BOM library to set the version of FB Analytics Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: declare Firebase dependencies in build.gradle file References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * test: use framework to set firebase-analytics version References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * refactor: declare Firebase dependencies in build.gradle file References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: enable Kotlin Context: This is necessary for MABS 9. We currently say that the current version of the plugin works with MABS 9 and MAS 10, but it actually doesn't work with MABS 9 because we use Kotlin code but do not enable the Kotlin plugin. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * test: enable AndroidX * chore: revert previous commit * fix: enable Kotlin Context: This is necessary for MABS 9. We currently say that the current version of the plugin works with MABS 9 and MAS 10, but it actually doesn't work with MABS 9 because we use Kotlin code but do not enable the Kotlin plugin. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: revert previous commit * test: include FB Analytics using framework * test: enable Kotlin * refactor: include FB dependencies in build.gradle References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore: revert previous commit that added Kotlin * chore: update changelog https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore(release): raise to version 5.0.0-OS14 References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * feat: ios setConsent * feat(android): add setConsent in android * chore: json parse * chore: fix android impl * chore: missed import * chore: more missing imports * chore: obj-c issues * chore: keep jsonstring * chore: fix array parse ios * chore: correct setConset param type * fix: helper methods * fix: cordova passing odd param * chore: changelog * chore: jsdoc update * chore: fix up * chore: missing import * chore: car clean up * chore: better error and logic handling * chore: typo * chore: enums instead of helper func * chore: clean up --------- Co-authored-by: Ricardo Silva <[email protected]> Co-authored-by: Alexandre Jacinto <[email protected]>
IT-MikeS
added a commit
that referenced
this pull request
Oct 10, 2024
* RMET-3608 - Prepare to release version `5.0.0-OS14` (#41) * RMET-3608 FB Analytics - Update dependency to Firebase Analytics Android SDK (#40) * feat: use Firebase Android BOM library to set the version of FB Analytics Context: According to the documentation, this is the recommended way of controlling Firebase library versions. This way, using the Firebase Android BOM, an app with multiple Firebase Android libraries will always use compatible versions of these libraries. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: declare Firebase dependencies in build.gradle file References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * test: use framework to set firebase-analytics version References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * refactor: declare Firebase dependencies in build.gradle file References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: enable Kotlin Context: This is necessary for MABS 9. We currently say that the current version of the plugin works with MABS 9 and MAS 10, but it actually doesn't work with MABS 9 because we use Kotlin code but do not enable the Kotlin plugin. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * test: enable AndroidX * chore: revert previous commit * fix: enable Kotlin Context: This is necessary for MABS 9. We currently say that the current version of the plugin works with MABS 9 and MAS 10, but it actually doesn't work with MABS 9 because we use Kotlin code but do not enable the Kotlin plugin. References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * fix: revert previous commit * test: include FB Analytics using framework * test: enable Kotlin * refactor: include FB dependencies in build.gradle References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore: revert previous commit that added Kotlin * chore: update changelog https://outsystemsrd.atlassian.net/browse/RMET-3608 * chore(release): raise to version 5.0.0-OS14 References: https://outsystemsrd.atlassian.net/browse/RMET-3608 * feat: ios setConsent * feat(android): add setConsent in android * chore: json parse * chore: fix android impl * chore: missed import * chore: more missing imports * chore: obj-c issues * chore: keep jsonstring * chore: fix array parse ios * chore: correct setConset param type * fix: helper methods * fix: cordova passing odd param * chore: changelog * chore: jsdoc update * chore: fix up * chore: missing import * chore: car clean up * chore: better error and logic handling * chore: typo * chore: enums instead of helper func * chore: clean up * chore: version bumps --------- Co-authored-by: Ricardo Silva <[email protected]> Co-authored-by: Alexandre Jacinto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merges
development
intooutsystems
.Context
References: https://outsystemsrd.atlassian.net/browse/RMET-3608
Type of changes
Platforms affected
Tests
Screenshots (if appropriate)
Checklist
RNMT-XXXX <title>