forked from chemerisuk/cordova-plugin-firebase-analytics
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMET-3341 ::: Prepare main
for Release 5.0.0-OS12
#36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parency prompt (#22) * fix: add function for requestTrackingAuthorization without promise References: https://outsystemsrd.atlassian.net/browse/RMET-2112 * fix: fixing function structure * test: testing with promise * test: testing with only 1 export * test: use module.exports * refactor: remove commented lines * chore: update changelog References: https://outsystemsrd.atlassian.net/browse/RMET-2112 * refactor: use constant
* feat: raise firebase core version
…parency prompt (#22) (#23) * fix: add function for requestTrackingAuthorization without promise References: https://outsystemsrd.atlassian.net/browse/RMET-2112 * fix: fixing function structure * test: testing with promise * test: testing with only 1 export * test: use module.exports * refactor: remove commented lines * chore: update changelog References: https://outsystemsrd.atlassian.net/browse/RMET-2112 * refactor: use constant
* feat: added logECommerceEvent javascript function * chore: updates CHANGELOG.md * feat: changed how ecommerce arguments are passed to the native side
Implement the logic required to perform e-commerce event logging. The implementation is similar to the already existing logEvent but without any parameter number constraints. Before logging, and considering that the Firebase Analytics library doesn't return any kind of error in case of any issues with the data, the implementation performs the following steps: #1 - Flat the Key-Value pair information to a JSON Object. This is done on both Event Parameters and Items. #2 - Validate if the event parameters and items are correctly constructed. Both validations are done isolated, with errors being handled and returned in case of occurrence. #3 - Validate the event parameters and items are valid according to the event name. This time, the validation is done altogether, with errors being handled and returned in case of occurrence. #4 - Merge event parameters and items into a single JSON object to be sent to Analytics for logging purposes. The implementation, since it's done using Swift, involves adding the Swift dependency to the `plugin.xml`. References: https://outsystemsrd.atlassian.net/browse/RMET-2731
Remove the default `quantity` value as this is already assured by Firebase. Fix the `item_list_id` and `item_list_name` as only the property set on the event parameters should be removed and not both always. File rename to match the structure name. References: https://outsystemsrd.atlassian.net/browse/RMET-2731
* feat: added ecommerce events first version * fix: added removed hook * fix: fixed bugs with happy paths * feat: added KDoc * fix: removed unecessry verification * chore: updated CHANGELOG * fix: applied changes suggested on the PR comments * fix: added missing bridge file * fix: applied proposed changes
* RMET-2112 FB Analytics - Return user's response to App Tracking Transparency prompt (#22) * fix: add function for requestTrackingAuthorization without promise References: https://outsystemsrd.atlassian.net/browse/RMET-2112 * fix: fixing function structure * test: testing with promise * test: testing with only 1 export * test: use module.exports * refactor: remove commented lines * chore: update changelog References: https://outsystemsrd.atlassian.net/browse/RMET-2112 * refactor: use constant * RMET-2441 :: raise firebase-core version (#24) * feat: raise firebase core version * chore(release): raise to version 5.0.0-OS10 --------- Co-authored-by: Marta Carlos <[email protected]>
Raises Pod version to 8.15.0 References: https://outsystemsrd.atlassian.net/browse/RMET-3140
Signed-off-by: IT-MikeS <[email protected]>
* chore: Update iOS SDK version Update iOS' 3rd party SDK version to `10.23.0`. Enable the `use_frameworks` flag for CocoaPods. Fix import errors. References: https://outsystemsrd.atlassian.net/browse/RMET-3274 * chore: Add CHANGELOG entry References: https://outsystemsrd.atlassian.net/browse/RMET-3274
Prepare release of `5.0.0-OS12`. Clean `CHANGELOG`. References: https://outsystemsrd.atlassian.net/browse/RMET-3341
OS-ricardomoreirasilva
force-pushed
the
development
branch
from
April 12, 2024 13:21
f4943c7
to
838a0ed
Compare
# Conflicts: # package.json # plugin.xml
Quality Gate passedIssues Measures |
OS-ricardomoreirasilva
requested review from
ItsChaceD,
IT-MikeS,
alexgerardojacinto,
hectorjdgdev and
OS-martacarlos
and removed request for
a team
April 12, 2024 13:27
OS-martacarlos
approved these changes
Apr 12, 2024
IT-MikeS
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge
development
intooutsystems
.Context
https://outsystemsrd.atlassian.net/browse/RMET-3341