Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3341 ::: Prepare main for Release 5.0.0-OS12 #36

Merged
merged 18 commits into from
Apr 15, 2024

Conversation

OS-ricardomoreirasilva
Copy link

@OS-ricardomoreirasilva OS-ricardomoreirasilva commented Apr 12, 2024

Description

Merge development into outsystems.

Context

https://outsystemsrd.atlassian.net/browse/RMET-3341

alexgerardojacinto and others added 16 commits January 13, 2023 18:39
…parency prompt (#22)

* fix: add function for requestTrackingAuthorization without promise

References: https://outsystemsrd.atlassian.net/browse/RMET-2112

* fix: fixing function structure

* test: testing with promise

* test: testing with only 1 export

* test: use module.exports

* refactor: remove commented lines

* chore: update changelog

References: https://outsystemsrd.atlassian.net/browse/RMET-2112

* refactor: use constant
* feat: raise firebase core version
…parency prompt (#22) (#23)

* fix: add function for requestTrackingAuthorization without promise

References: https://outsystemsrd.atlassian.net/browse/RMET-2112

* fix: fixing function structure

* test: testing with promise

* test: testing with only 1 export

* test: use module.exports

* refactor: remove commented lines

* chore: update changelog

References: https://outsystemsrd.atlassian.net/browse/RMET-2112

* refactor: use constant
* feat: added logECommerceEvent javascript function

* chore: updates CHANGELOG.md

* feat: changed how ecommerce arguments are passed to the native side
Implement the logic required to perform e-commerce event logging. The implementation is similar to the already existing logEvent but without any parameter number constraints.

Before logging, and considering that the Firebase Analytics library doesn't return any kind of error in case of any issues with the data, the implementation performs the following steps:
#1 - Flat the Key-Value pair information to a JSON Object. This is done on both Event Parameters and Items.
#2 - Validate if the event parameters and items are correctly constructed. Both validations are done isolated, with errors being handled and returned in case of occurrence.
#3 - Validate the event parameters and items are valid according to the event name. This time, the validation is done altogether, with errors being handled and returned in case of occurrence.
#4 - Merge event parameters and items into a single JSON object to be sent to Analytics for logging purposes.

The implementation, since it's done using Swift, involves adding the Swift dependency to the `plugin.xml`.

References: https://outsystemsrd.atlassian.net/browse/RMET-2731
Remove the default `quantity` value as this is already assured by Firebase.
Fix the `item_list_id` and `item_list_name` as only the property set on the event parameters should be removed and not both always.
File rename to match the structure name.

References: https://outsystemsrd.atlassian.net/browse/RMET-2731
* feat: added ecommerce events first version

* fix: added removed hook

* fix: fixed bugs with happy paths

* feat: added KDoc

* fix: removed unecessry verification

* chore: updated CHANGELOG

* fix: applied changes suggested on the PR comments

* fix: added missing bridge file

* fix: applied proposed changes
* RMET-2112 FB Analytics - Return user's response to App Tracking Transparency prompt (#22)

* fix: add function for requestTrackingAuthorization without promise

References: https://outsystemsrd.atlassian.net/browse/RMET-2112

* fix: fixing function structure

* test: testing with promise

* test: testing with only 1 export

* test: use module.exports

* refactor: remove commented lines

* chore: update changelog

References: https://outsystemsrd.atlassian.net/browse/RMET-2112

* refactor: use constant

* RMET-2441 :: raise firebase-core version (#24)

* feat: raise firebase core version

* chore(release): raise to version 5.0.0-OS10

---------

Co-authored-by: Marta Carlos <[email protected]>
* chore: Update iOS SDK version

Update iOS' 3rd party SDK version to `10.23.0`.
Enable the `use_frameworks` flag for CocoaPods.
Fix import errors.

References: https://outsystemsrd.atlassian.net/browse/RMET-3274

* chore: Add CHANGELOG entry

References: https://outsystemsrd.atlassian.net/browse/RMET-3274
Prepare release of `5.0.0-OS12`.
Clean `CHANGELOG`.

References: https://outsystemsrd.atlassian.net/browse/RMET-3341
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@OS-ricardomoreirasilva OS-ricardomoreirasilva marked this pull request as ready for review April 12, 2024 13:27
@OS-ricardomoreirasilva OS-ricardomoreirasilva requested a review from a team as a code owner April 12, 2024 13:27
@OS-ricardomoreirasilva OS-ricardomoreirasilva merged commit 33d1c74 into outsystems Apr 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants