forked from apache/cordova-plugin-contacts
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMET-3263 create CODEOWNERS file #11
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding OutSystems extensibility configuration
RNMT-2225 Fix contacts permissions for Android 8+
Updated to 3.0.1-OS1
Clone and setup of automation framework
Implement 2 P0's
The import of the constants (default_timeout and default_timeout_interval) has been changed
…com/OutSystems/cordova-plugin-contacts into RNMT-3066-(Automatic-Tests)" This reverts commit bf39cbc, reversing changes made to 77e5dd0.
RMET-562 - Contacts Plugin: Application crashes when trying to pick contact
Add Pipelines
…ons-dialog RMET-1301 Contacts Plugin - Show no permissions dialog when permissions are denied
IT-MikeS
requested review from
alexgerardojacinto,
giocalitri,
ItsChaceD,
OS-martacarlos and
OS-ricardomoreirasilva
March 15, 2024 14:57
alexgerardojacinto
approved these changes
Mar 15, 2024
OS-martacarlos
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be merged into the outsystems
branch, not master
IT-MikeS
force-pushed
the
chore/add-codeowner-file-initiative
branch
from
March 15, 2024 18:22
36a83e9
to
e988e0e
Compare
The explanation of the contactFields argument in the 'navigator.contacts.find' section is unclear and ambiguous. Updating to make it clearer to people wanting to utilise this plugin.
reformat warning and add horizontal lines hide deprecated platforms quirks behind <details> resort supported platforms fix tiny errors
Signed-off-by: IT-MikeS <[email protected]>
IT-MikeS
force-pushed
the
chore/add-codeowner-file-initiative
branch
from
March 18, 2024 15:23
e988e0e
to
dccf734
Compare
}); | ||
|
||
function archiveBuild(buildPath, appName, filename) { | ||
exec("az pipelines runs artifact upload --artifact-name '" + appName + "." + filename + "' --path '" + buildPath + "' --run-id '" + runID +"'", (error, stdout, stderr) => { |
Check warning
Code scanning / CodeQL
Shell command built from environment values Medium
This shell command depends on an uncontrolled .
This shell command depends on an uncontrolled .
file name
Error loading related location
Loading This shell command depends on an uncontrolled
file name
Error loading related location
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the required CODEOWNERS file to the repo with a comment designating if the plugin relates to ODC or O11 or both.
Context
New requirements before March 15th 2024, all repos must have a CODEOWNERS file.
Issue Link
Type of changes
Platforms affected