Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3982 - Update workflow to publish library under io.ionic.libs #41

Merged
merged 13 commits into from
Jan 29, 2025

Conversation

alexgerardojacinto
Copy link
Collaborator

Description

  • Updates publish-android workflow and other configuration files so that library is published under io.ionic.libs instead of com.capacitorjs.
  • Also updates library name on Maven to ioninappbrowser-android, following the same pattern we used for https://github.com/ionic-team/ion-android-geolocation
  • Also removes unnecessary environment variables being passed into the publish-android.sh script

Context

References: https://outsystemsrd.atlassian.net/browse/RMET-3982

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Platforms affected

  • Android
  • iOS
  • JavaScript

Tests

  • Tested publishing stating version of library under io.ionic.libs, which was successful.

Screenshots (if appropriate)

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@alexgerardojacinto alexgerardojacinto self-assigned this Jan 28, 2025
@alexgerardojacinto alexgerardojacinto merged commit aea0970 into development Jan 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants