RMET-2770 ::: Barcode scanner screen for phones #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: We should use a @composable function for each element on the screen. References: https://outsystemsrd.atlassian.net/browse/RMET-2770
Context: These two buttons should be aligned, with the scan button at the center, and the flashlight button at the right-most corner. This commit also includes some refactoring on the Close button. References: https://outsystemsrd.atlassian.net/browse/RMET-2770
Context: The scanning view should be full screen, as in the Figma design. References: https://outsystemsrd.atlassian.net/browse/RMET-2770
Context: We check if the device's orientation is portrait or landscape, all call the respective UI composable method - ScanScreenUIPortrait or ScanScreenUILandscape. References: https://outsystemsrd.atlassian.net/browse/RMET-2770
…t on portrait screen
nflsilva
requested review from
hectorjdgdev,
OS-ricardomoreirasilva and
OS-martacarlos
src/main/kotlin/com/outsystems/plugins/barcode/view/ui.theme/Theme.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/outsystems/plugins/barcode/view/OSBARCScannerActivity.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/outsystems/plugins/barcode/view/OSBARCScannerActivity.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/outsystems/plugins/barcode/view/OSBARCScannerActivity.kt
Outdated
Show resolved
Hide resolved
…izes to a constants file.
|
Kudos, SonarCloud Quality Gate passed! |
OS-ricardomoreirasilva
approved these changes
Dec 4, 2023
hectorjdgdev
approved these changes
Dec 5, 2023
hectorjdgdev
reviewed
Dec 5, 2023
src/main/kotlin/com/outsystems/plugins/barcode/view/OSBARCScannerActivity.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR performs the following changes:
Context
https://outsystemsrd.atlassian.net/browse/RMET-2770
Type of changes
Platforms affected
Tests
Since this is UI implementation. No automated tests were created.
Solution was tested on a real device on Android 11.
Screenshots (if appropriate)
Portrait
Landscape
Checklist
RNMT-XXXX <title>