Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3837 - Prepare to release version 1.1.5 #39

Merged
merged 3 commits into from
Nov 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

The changes documented here do not include those from the original repository.

## [1.1.5]

### 08-11-2024
- Fix: Update libraries for supporting 16KB page size (https://outsystemsrd.atlassian.net/browse/RMET-3602)

### 05-11-2024
- Fix: Edge-to-edge support on Android 15 (https://outsystemsrd.atlassian.net/browse/RMET-3597)

## [1.1.4]

### 08-10-2024
Expand Down
11 changes: 6 additions & 5 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -108,19 +108,20 @@ dependencies {
implementation "androidx.activity:activity-compose:1.4.0"
implementation 'androidx.compose.material3:material3:1.0.0'
implementation 'androidx.compose.material3:material3-window-size-class:1.0.0'
implementation 'androidx.window:window:1.3.0'

testImplementation 'junit:junit:4.13.2'
androidTestImplementation 'androidx.test.ext:junit:1.1.3'
androidTestImplementation 'androidx.test.espresso:espresso-core:3.4.0'
androidTestImplementation "androidx.compose.ui:ui-test-junit4:1.0.5"
debugImplementation "androidx.compose.ui:ui-tooling:1.0.5"

implementation "androidx.camera:camera-camera2:1.3.0"
implementation 'androidx.camera:camera-lifecycle:1.0.2'
implementation 'androidx.camera:camera-view:1.0.0-alpha31'
implementation 'androidx.camera:camera-core:1.0.0'
implementation "androidx.camera:camera-camera2:1.4.0"
implementation 'androidx.camera:camera-lifecycle:1.4.0'
implementation 'androidx.camera:camera-view:1.4.0'
implementation 'androidx.camera:camera-core:1.4.0'
implementation 'com.google.zxing:core:3.4.1'
implementation 'com.google.mlkit:barcode-scanning:17.2.0'
implementation 'com.google.mlkit:barcode-scanning:17.3.0'
implementation 'com.google.code.gson:gson:2.10.1'

testImplementation "org.mockito:mockito-core:4.3.0"
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.github.outsystems</groupId>
<artifactId>osbarcode-android</artifactId>
<version>1.1.4</version>
<version>1.1.5</version>
</project>
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.Path
import androidx.compose.ui.graphics.drawscope.Stroke
import androidx.compose.ui.graphics.drawscope.clipPath
import androidx.compose.ui.graphics.toComposeRect
import androidx.compose.ui.layout.onGloballyPositioned
import androidx.compose.ui.platform.LocalConfiguration
import androidx.compose.ui.platform.LocalContext
Expand All @@ -89,6 +90,7 @@ import androidx.compose.ui.unit.dp
import androidx.compose.ui.viewinterop.AndroidView
import androidx.core.content.ContextCompat
import androidx.core.view.WindowCompat
import androidx.window.layout.WindowMetricsCalculator
import com.outsystems.plugins.barcode.R
import com.outsystems.plugins.barcode.controller.OSBARCBarcodeAnalyzer
import com.outsystems.plugins.barcode.controller.OSBARCScanLibraryFactory
Expand Down Expand Up @@ -286,7 +288,6 @@ class OSBARCScannerActivity : ComponentActivity() {
Box(
modifier = Modifier
.fillMaxSize()
.safeDrawingPadding()
) {
AndroidView(
factory = { context ->
Expand Down Expand Up @@ -338,8 +339,13 @@ class OSBARCScannerActivity : ComponentActivity() {
fun ScanScreenUI(parameters: OSBARCScanParameters, windowSizeClass: WindowSizeClass) {
// actual UI on top of the camera stream
val configuration = LocalConfiguration.current
screenHeight = configuration.screenHeightDp.dp
screenWidth = configuration.screenWidthDp.dp
val windowMetrics =
WindowMetricsCalculator.getOrCreate().computeCurrentWindowMetrics(this)
val rect = windowMetrics.bounds.toComposeRect()
with(LocalDensity.current) {
screenHeight = rect.height.toDp()
screenWidth = rect.width.toDp()
}

val isPortrait = configuration.orientation == Configuration.ORIENTATION_PORTRAIT

Expand Down Expand Up @@ -505,7 +511,8 @@ class OSBARCScannerActivity : ComponentActivity() {
modifier = Modifier
.fillMaxWidth()
.background(ScannerBackgroundBlack)
.weight(1f, fill = true),
.weight(1f, fill = true)
.safeDrawingPadding(),
) {
CloseButton(
modifier = Modifier
Expand Down Expand Up @@ -541,7 +548,8 @@ class OSBARCScannerActivity : ComponentActivity() {
modifier = Modifier
.fillMaxWidth()
.background(ScannerBackgroundBlack)
.weight(1f, fill = true),
.weight(1f, fill = true)
.safeDrawingPadding(),
) {
val showTorch = camera.cameraInfo.hasFlashUnit()
val showScan = parameters.scanButton
Expand Down Expand Up @@ -651,6 +659,7 @@ class OSBARCScannerActivity : ComponentActivity() {
rightButtonsWidth = with(density) { coordinates.size.width.toDp() }
}
.background(ScannerBackgroundBlack)
.safeDrawingPadding()
) {

CloseButton(
Expand Down