Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RMET-3682 ::: Make Scanner View Wider #35

Merged
merged 7 commits into from
Oct 17, 2024

Conversation

ItsChaceD
Copy link
Contributor

@ItsChaceD ItsChaceD commented Oct 9, 2024

Description

Improved scanning area width for large barcodes by dynamically calculating the right button area width and adjusting the scanner view accordingly for phones in landscape and tablet layouts in both portrait and landscape orientations.

Context

https://outsystemsrd.atlassian.net/browse/RMET-3682

Type of changes

  • Fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Refactor (cosmetic changes)
  • Breaking change (change that would cause existing functionality to not work as expected)

Tests

Tested on Pixel 8 Pro
Tested on Pixel Tablet Emulator

Screenshots

BEFORE
Screenshot_20241009-160107

AFTER
Screenshot_20241009-160248

Checklist

  • Pull request title follows the format RNMT-XXXX <title>
  • Code follows code style of this project
  • CHANGELOG.md file is correctly updated
  • Changes require an update to the documentation
    • Documentation has been updated accordingly

@ItsChaceD ItsChaceD requested a review from a team as a code owner October 9, 2024 00:47
@ItsChaceD ItsChaceD requested review from IT-MikeS, alexgerardojacinto, OS-ricardomoreirasilva and OS-martacarlos and removed request for a team October 9, 2024 00:47
Copy link
Contributor

@OS-ricardomoreirasilva OS-ricardomoreirasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something wrong with the white right edge of the scanning area. It was already looking weird, but now the line looks even thinner.

@alexgerardojacinto
Copy link
Collaborator

Apart from Ricardo's comment, there also appears to be something wrong with the zoom buttons, possibly because there's not enough space for them.

@ItsChaceD
Copy link
Contributor Author

ItsChaceD commented Oct 9, 2024

There's something wrong with the white right edge of the scanning area. It was already looking weird, but now the line looks even thinner.

I didn't even notice 😅 I will take a look and see what's going on.

Apart from Ricardo's comment, there also appears to be something wrong with the zoom buttons, possibly because there's not enough space for them.

We can keep the 3 buttons, but then the scanning view won't be as wide. Which do you think is better?

@alexgerardojacinto
Copy link
Collaborator

We can keep the 3 buttons, but then the scanning view won't be as wide. Which do you think is better?

@ItsChaceD I think we should keep the buttons and have the scanning view the maximum that it can be without "loosing" any buttons.

@ItsChaceD
Copy link
Contributor Author

We can keep the 3 buttons, but then the scanning view won't be as wide. Which do you think is better?

@ItsChaceD I think we should keep the buttons and have the scanning view the maximum that it can be without "loosing" any buttons.

Ok sounds good to me! On devices without the <1x zoom which is where the large barcode problems were primarily, it will look like the picture anyways

@OS-ricardomoreirasilva
Copy link
Contributor

We can keep the 3 buttons, but then the scanning view won't be as wide. Which do you think is better?

@ItsChaceD I think we should keep the buttons and have the scanning view the maximum that it can be without "loosing" any buttons.

The design to follow (with the area and the 3 buttons) is available here.

@ItsChaceD
Copy link
Contributor Author

ItsChaceD commented Oct 9, 2024

We can keep the 3 buttons, but then the scanning view won't be as wide. Which do you think is better?

@ItsChaceD I think we should keep the buttons and have the scanning view the maximum that it can be without "loosing" any buttons.

The design to follow (with the area and the 3 buttons) is available here.

Yeah can you screenshot it for me please? I have tried requesting access a few times but they never got back to me.
Looks like I have access now :)

@ItsChaceD ItsChaceD force-pushed the fix/RMET-3682/wider-scanner-view branch 3 times, most recently from 6061f94 to dbd533b Compare October 16, 2024 15:59
@ItsChaceD ItsChaceD force-pushed the fix/RMET-3682/wider-scanner-view branch from dbd533b to 353c528 Compare October 16, 2024 16:01
Copy link

@ItsChaceD ItsChaceD merged commit 27f00e4 into development Oct 17, 2024
7 checks passed
@ItsChaceD ItsChaceD deleted the fix/RMET-3682/wider-scanner-view branch October 17, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants