-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RMET-3682 ::: Make Scanner View Wider #35
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's something wrong with the white right edge of the scanning area. It was already looking weird, but now the line looks even thinner.
Apart from Ricardo's comment, there also appears to be something wrong with the zoom buttons, possibly because there's not enough space for them. |
I didn't even notice 😅 I will take a look and see what's going on.
We can keep the 3 buttons, but then the scanning view won't be as wide. Which do you think is better? |
@ItsChaceD I think we should keep the buttons and have the scanning view the maximum that it can be without "loosing" any buttons. |
Ok sounds good to me! On devices without the <1x zoom which is where the large barcode problems were primarily, it will look like the picture anyways |
The design to follow (with the area and the 3 buttons) is available here. |
|
src/main/kotlin/com/outsystems/plugins/barcode/view/OSBARCScannerActivity.kt
Outdated
Show resolved
Hide resolved
6061f94
to
dbd533b
Compare
dbd533b
to
353c528
Compare
Quality Gate passedIssues Measures |
Description
Improved scanning area width for large barcodes by dynamically calculating the right button area width and adjusting the scanner view accordingly for phones in landscape and tablet layouts in both portrait and landscape orientations.
Context
https://outsystemsrd.atlassian.net/browse/RMET-3682
Type of changes
Tests
Tested on Pixel 8 Pro
Tested on Pixel Tablet Emulator
Screenshots
BEFORE
AFTER
Checklist
RNMT-XXXX <title>