Tests for the IO module #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RondeauG
commented
Nov 14, 2024
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
5 tasks
juliettelavoie
approved these changes
Nov 15, 2024
Zeitsperre
added a commit
to Ouranosinc/xclim
that referenced
this pull request
Nov 15, 2024
### What kind of change does this PR introduce? * Fixed an issue that was causing URLs to include a `//` between the repository and branch fields. ### Does this PR introduce a breaking change? No. ### Other information: While this was working fine for returning files already available on disk, when `nimbus` was fetching files remotely when launched from a Jupyter notebook, this was failing. Related: Ouranosinc/xscen#492
RondeauG
commented
Nov 18, 2024
for more information, see https://pre-commit.ci
aulemahal
reviewed
Nov 19, 2024
Co-authored-by: Pascal Bourgault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
openpyxl) to the requirements.estimate_chunksto support n dimensions.subset_maxsizewhere the last year would be dropped.clean_incompletewhere thezmetadatafile would not be removed.clean_incomplete._coerce_attrswhere encoding would get dropped.save_to_zarrwithmode=='a': encoding of existing variables is now always dropped & the code now crashes if trying to both append dimensions with new data and add a new variable to an existing zarr.save_to_zarrwhere the code would crash when skipping a variable ifbitroundwas not None.make_tocwhere the French name for the sheet would get dropped if given a Dataset instead of a DataArray.columninsave_to_table. It stays unchanged if given a Dataset with multiple variables, but is nowNoneotherwise.save_to_tablewhereengine_kwargswould not be used if saving an Excel with a single sheet.publish_release_notesto only print the notes relevant to the latest version, rather than the whole Changelog.Does this PR introduce a breaking change?
-To remove some clutter,
publish_release_notesandshow_versionshave been moved fromutils.pytotesting.py.Other information: