Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More flexible produce_horizon #483

Merged
merged 12 commits into from
Nov 4, 2024
Merged

More flexible produce_horizon #483

merged 12 commits into from
Nov 4, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Oct 25, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • You can now skip the computation of indicators, if you've already done that step and just want the subsetting/climatological_op utilities of produce_horizon.
  • You can now control the op in produce_horizon.
  • Fixed a bug in compute_indicators where the cat:variable was determined too early and only gave the first indicator even when multiple were computed.

Does this PR introduce a breaking change?

  • indicators was moved to a kwarg, since it is now optional.

Other information:

juliettelavoie
juliettelavoie approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@juliettelavoie juliettelavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

src/xscen/aggregate.py Show resolved Hide resolved
@RondeauG RondeauG merged commit 6abe87b into main Nov 4, 2024
16 checks passed
@RondeauG RondeauG deleted the small_changes branch November 4, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliettelavoie juliettelavoie juliettelavoie approved these changes

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RondeauG @juliettelavoie