Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip "root" dirs too #479

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Skip "root" dirs too #479

merged 2 commits into from
Oct 21, 2024

Conversation

aulemahal
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Small fix upon #478. Skips even if a directory to skip is one of the entries in directory or a parent of one of the entries.
I implemented it because I misunderstood an error I was having, but still, this could be used in the specific scenario where you are running parse_directory through an incremental stack of xscen configurations. To remove en entry of the directories list of a previous configuration, you would only need to add a skip_dirs entry, and not rewrite the filtered directories.

This also adds logging calls when skipping. And a precision to the doc about the absoluteness of paths to skip.

Does this PR introduce a breaking change?

No.

Other information:

@aulemahal aulemahal requested a review from RondeauG October 21, 2024 14:15
Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@aulemahal aulemahal merged commit 0af9f5a into main Oct 21, 2024
16 checks passed
@aulemahal aulemahal deleted the parse-dir-skip-bis branch October 21, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants