Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Small fix upon #478. Skips even if a directory to skip is one of the entries in
directory
or a parent of one of the entries.I implemented it because I misunderstood an error I was having, but still, this could be used in the specific scenario where you are running
parse_directory
through an incremental stack of xscen configurations. To remove en entry of thedirectories
list of a previous configuration, you would only need to add askip_dirs
entry, and not rewrite the filtereddirectories
.This also adds logging calls when skipping. And a precision to the doc about the absoluteness of paths to skip.
Does this PR introduce a breaking change?
No.
Other information: