-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add oblique mercator to create_bounds
and other improvements to the regridding function
#467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RondeauG
changed the title
Add oblique mercator to
Add oblique mercator to Sep 26, 2024
create_bounds
create_bounds
and other improvements to the regridding function
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
RondeauG
commented
Sep 26, 2024
aulemahal
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good!
juliettelavoie
approved these changes
Sep 26, 2024
aulemahal
reviewed
Sep 26, 2024
Co-authored-by: Pascal Bourgault <[email protected]>
…lique_mercator_bounds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
create_bounds_rotated_pole
tocreate_bounds_gridmapping
and adds support foroblique_mercator
.regrid_dataset
:weights_location
is now optional.cat:id
andcat:domain
for both the incoming dataset and the grid.lon_bounds
andlat_bounds
variables if the grid was generated usingxesmf.util.cf_grid_2d
create_mask
has been completely refactored to use real arguments instead of a dictionary.Does this PR introduce a breaking change?
weights_location
inregrid_dataset
is now optional, and thus had to be moved to explicit arguments rather than positional.Other information: