Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cookiecutter update #452

Merged
merged 19 commits into from
Sep 17, 2024
Merged

Cookiecutter update #452

merged 19 commits into from
Sep 17, 2024

Conversation

Zeitsperre
Copy link
Contributor

@Zeitsperre Zeitsperre commented Sep 11, 2024

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Updates the cookiecutter template to the latest commit
  • CI now uses a CI folder to manage pip dependencies
  • checks for YAML format and code quality are stricter (via ruff)
  • Python3.13 has been added to the list of supported Python versions
  • Development dependency and documentation updates
  • flake8-alphabetize has been replaced by ruff
  • numpydoc-validate has been staged for integration in linting
  • There is now a license statement in the top-level __init__.py

Does this PR introduce a breaking change?

Not really. The linting checks are more intense.

Other information:

numpydoc-validate is not enabled since the changes are significant and require input from multiple developers. These should come about in another PR.

@Zeitsperre Zeitsperre added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels Sep 11, 2024
@Zeitsperre Zeitsperre self-assigned this Sep 11, 2024
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
src/xscen/catalog.py Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@Zeitsperre Zeitsperre merged commit 0535d0c into main Sep 17, 2024
16 of 17 checks passed
@Zeitsperre Zeitsperre deleted the cookiecutter-update branch September 17, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants