-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take translation out of the build process #443
Conversation
As seen on the failure of commit aaee623, the new CI element works as expected. |
And I checked: installing from this branch with "pip git+https://..." works, while it does not for main. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!
Co-authored-by: Trevor James Smith <[email protected]>
@aulemahal Do we want to enable the French RTD documentation in this PR as well? |
Je ne pense pas qu'il y ait un besoin et je ne suis personnellement pas à tout à fait à l'aise avec une traduction automatique. |
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
make translate
on each clone of the source.make checkfrench
ensures that the french catalog is up-to-date AND that the compiled version is older than the catalog. See notes.checkfrench
so a PR adding translatable messages cannot be merged if the french translation is not given.Does this PR introduce a breaking change?
No.
The only change is for developers.
make translate
needs only to be run if a translatable message was added, aftermake findfrench
was run and the "xscen.po" file updated with the french translation. So, exactly what the contributing guide says to do.Other information:
The date check on
mo
files is weak : a catalog file could have a modified time changed even tough no real change was done. And (in theory) a compiled file could have a recent date even though it is not in sync wit the catalog. However, binary comparion of twomo
files taken from the same catalog fails. My guess is that the compilation time is included in the mo file, and I didn't want to dig deeper. We don't update the translation catalogs often, so this should be enough.@Zeitsperre This removes the
setup.py
stuff. Feel free to change the build system if you feel like doing so!