-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update cookiecutter, adopt pyproject.toml #292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… publishing, migrate settings to pyproject.toml and .flake8, rename black to lint, consistency in Makefile calls, add actions-version-updater
github-actions
bot
added
the
xclim
Additions to xclim_modules or improvement for xclim
label
Nov 27, 2023
I have two commits waiting to resolve (?). Once those are in, feel free to review! Edit: They're in. |
Zeitsperre
requested review from
RondeauG and
aulemahal
and removed request for
RondeauG
November 27, 2023 20:27
RondeauG
reviewed
Nov 28, 2023
RondeauG
reviewed
Nov 28, 2023
Co-authored-by: RondeauG <[email protected]>
# Conflicts: # setup.py
aulemahal
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new convention seems nicer!
We'll need to modify |
Co-authored-by: Pascal Bourgault <[email protected]>
Co-authored-by: Pascal Bourgault <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
bump-my-version
instead ofbump2version
.ruff
for the majority of checks, with minimalflake8
-based checks (until such a time that these checks are ported toruff
).setuptools
-relevant information.babel
configurations have migrated to.flake8
andpyproject.toml
.tox
builds are now more pure Python build friendly.pre-commit
now has hooks for TOML files, JSON schemas, andruff
.Does this PR introduce a breaking change?
There are no behavioural changes for users or developers, but the build system configurations are now more centralized into
pyproject.toml
.bump2version
has been replaced withbump-my-version
(maintained;pyproject.toml
support).setup.py
has been mostly hollowed out. The only function remaining is that which generate the translations. This approach is the recommended way to maintainsetup.py
functionality in the new build system.The contents of the wheel are set within
pyproject.toml
while those of the source distribution are still set viaMANIFEST.in
, similar to how it was configured before.Other information:
https://setuptools.pypa.io/en/latest/userguide/pyproject_config.html
https://docs.pypi.org/trusted-publishers/using-a-publisher/
What's missing?
The PR summary of changes needs to be fully describedLinting checks need to be reconfigured forruff
Trusted Publishing needs to be configured