Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select the set of indicators for available variables #291

Merged
merged 20 commits into from
Dec 5, 2023
Merged

Select the set of indicators for available variables #291

merged 20 commits into from
Dec 5, 2023

Conversation

vindelico
Copy link
Collaborator

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • This PR does not seem to break the templates.
  • HISTORY.rst has been updated (with summary of main changes).
    • Link to pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Adds the function xscen.indicators.select_inds_for_avail_vars to filter the indicators that can be calculated with the variables available in a xarray.Dataset.

Does this PR introduce a breaking change?

No.

Other information:

RondeauG
RondeauG approved these changes Nov 27, 2023
View reviewed changes
Copy link
Collaborator

@RondeauG RondeauG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The only thing that's maybe missing is a check to handle the cases where no match is found (+associated test).

tests/test_indicators.py Outdated Show resolved Hide resolved
xscen/indicators.py Outdated Show resolved Hide resolved
xscen/indicators.py Outdated Show resolved Hide resolved
xscen/indicators.py Outdated Show resolved Hide resolved
xscen/indicators.py Outdated Show resolved Hide resolved
xscen/indicators.py Outdated Show resolved Hide resolved
xscen/indicators.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added CI Modifications to autiomation utilities xclim Additions to xclim_modules or improvement for xclim docs labels Dec 1, 2023
@github-actions github-actions bot removed CI Modifications to autiomation utilities xclim Additions to xclim_modules or improvement for xclim docs labels Dec 2, 2023
juliettelavoie
juliettelavoie approved these changes Dec 5, 2023
View reviewed changes
xscen/indicators.py Outdated Show resolved Hide resolved
@vindelico vindelico merged commit 53f08d5 into climatological_op Dec 5, 2023
18 checks passed
@vindelico vindelico deleted the select_indicators_for_available_vars branch December 5, 2023 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

@juliettelavoie juliettelavoie juliettelavoie approved these changes

@aulemahal aulemahal Awaiting requested review from aulemahal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vindelico @juliettelavoie @RondeauG